From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Derek Basehore <dbasehore@chromium.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Wolfram Sang <wsa@the-dreams.de>,
linux-i2c <linux-i2c@vger.kernel.org>,
Douglas Anderson <dianders@chromium.org>,
Dmitry Torokhov <dtor@chromium.org>,
venkateswarlu.v.vinjamuri@intel.corp-partner.google.com
Subject: Re: [PATCH] i2c: enable async suspend/resume on i2c devices
Date: Fri, 27 Jul 2018 14:07:11 +0200 [thread overview]
Message-ID: <1c3aba3d-0dfb-dc24-bd7a-5289a19a9065@redhat.com> (raw)
In-Reply-To: <CAHp75VfXXdzmp7M8rpcYTTKzwMT=QKt=_m7m7Bfp7uM4izMkrQ@mail.gmail.com>
Hi,
On 07/27/2018 12:44 PM, Andy Shevchenko wrote:
> On Fri, Jul 27, 2018 at 1:55 AM, Derek Basehore <dbasehore@chromium.org> wrote:
>> This enables the async suspend property for i2c devices. This reduces
>> the suspend/resume time considerably on platforms with multiple i2c
>> devices (such as a trackpad or touchscreen).
>
> How did you test this?
>
> Especially on Chromebooks based on Intel Cherrytrail / Braswell
> platforms, they have a painful PMIC vs. OS design solution.
>
> +Cc: Hans, who did a lot in this area.
We disable suspend of the i2c controller for the i2c-bus
to which the PMIc is connected on these platforms, so I do not
expect this to cause any new issues.
But this is something to keep an eye on,
Regards,
Hans
next prev parent reply other threads:[~2018-07-27 12:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 22:55 [PATCH] i2c: enable async suspend/resume on i2c devices Derek Basehore
2018-07-27 10:44 ` Andy Shevchenko
2018-07-27 12:07 ` Hans de Goede [this message]
2018-07-27 16:17 ` dbasehore .
2018-08-14 17:52 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2020-03-27 15:19 Ricardo Cañuelo
2020-03-27 15:43 ` Wolfram Sang
2020-03-27 20:26 ` dbasehore .
2020-03-29 10:24 ` Ricardo Cañuelo
2020-03-29 12:49 ` Ezequiel Garcia
2020-04-08 5:06 ` dbasehore .
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c3aba3d-0dfb-dc24-bd7a-5289a19a9065@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy.shevchenko@gmail.com \
--cc=dbasehore@chromium.org \
--cc=dianders@chromium.org \
--cc=dtor@chromium.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=venkateswarlu.v.vinjamuri@intel.corp-partner.google.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).