From: Alex Elder <elder@riscstar.com>
To: Troy Mitchell <troy.mitchell@linux.spacemit.com>,
Lee Jones <lee@kernel.org>, Yixun Lan <dlan@gentoo.org>,
Andi Shyti <andi.shyti@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-i2c@vger.kernel.org,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH v3 4/4] mfd: simple-mfd-i2c: add default value
Date: Tue, 18 Nov 2025 11:32:54 -0600 [thread overview]
Message-ID: <1c43aa3d-a5e6-4260-9079-fdc2e05c533c@riscstar.com> (raw)
In-Reply-To: <20251118-p1-kconfig-fix-v3-4-8839c5ac5db3@linux.spacemit.com>
On 11/18/25 12:08 AM, Troy Mitchell wrote:
> The default value of the P1 sub-device depends on the value
> of P1, so P1 should have a default value here.
>
> Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 6cec1858947bf7ab5ee78beb730c95dabcb43a98..b0f109b3acc40b074e4d0178e123437495853496 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1260,6 +1260,7 @@ config MFD_SPACEMIT_P1
> depends on I2C
> select I2C_K1
> select MFD_SIMPLE_MFD_I2C
> + default ARCH_SPACEMIT
> help
> This option supports the I2C-based SpacemiT P1 PMIC, which
> contains regulators, a power switch, GPIOs, an RTC, and more.
>
I agree with Emil on making this be default m if possible.
Acked-by: Alex Elder <elder@riscstar.com>
Thank you for these fixes.
next prev parent reply other threads:[~2025-11-18 17:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 6:08 [PATCH v3 0/4] fix the SpacemiT P1 Kconfig and resend the K1 I2C ILCR patch Troy Mitchell
2025-11-18 6:08 ` [PATCH v3 1/4] i2c: spacemit: configure ILCR for accurate SCL frequency Troy Mitchell
2025-11-18 17:32 ` Alex Elder
2025-12-26 5:58 ` Troy Mitchell
2025-12-26 7:52 ` Troy Mitchell
2025-12-29 0:58 ` Alex Elder
2025-12-29 1:20 ` Troy Mitchell
2025-11-18 6:08 ` [PATCH v3 2/4] rtc: spacemit: MFD_SPACEMIT_P1 as dependencies Troy Mitchell
2025-11-18 17:32 ` Alex Elder
2025-12-08 22:10 ` (subset) " Alexandre Belloni
2025-11-18 6:08 ` [PATCH v3 3/4] regulator: " Troy Mitchell
2025-11-18 17:32 ` Alex Elder
2025-11-18 6:08 ` [PATCH v3 4/4] mfd: simple-mfd-i2c: add default value Troy Mitchell
2025-11-18 16:16 ` Emil Renner Berthing
2025-11-18 17:32 ` Alex Elder [this message]
2025-12-19 8:10 ` [PATCH v3 0/4] fix the SpacemiT P1 Kconfig and resend the K1 I2C ILCR patch patchwork-bot+linux-riscv
2025-12-19 11:26 ` Lee Jones
2025-12-22 9:36 ` Troy Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c43aa3d-a5e6-4260-9079-fdc2e05c533c@riscstar.com \
--to=elder@riscstar.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andi.shyti@kernel.org \
--cc=broonie@kernel.org \
--cc=dlan@gentoo.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=troy.mitchell@linux.spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox