From: Krzysztof Kozlowski <krzk@kernel.org>
To: Aniket Randive <aniket.randive@oss.qualcomm.com>,
mukesh.savaliya@oss.qualcomm.com,
viken.dadhaniya@oss.qualcomm.com, andi.shyti@kernel.org,
sumit.semwal@linaro.org, christian.koenig@amd.com
Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
naresh.maramaina@oss.qualcomm.com
Subject: Re: [PATCH v1] i2c: qcom-geni: Add dynamic transfer timeout based on transfer length and frequency
Date: Mon, 6 Jul 2026 07:58:25 +0200 [thread overview]
Message-ID: <1edb643c-1d09-4ad8-97df-66c86e6123c5@kernel.org> (raw)
In-Reply-To: <20260705134619.4030745-1-aniket.randive@oss.qualcomm.com>
On 05/07/2026 15:46, Aniket Randive wrote:
> The driver uses a static XFER_TIMEOUT of HZ (1 second) for all transfers
> regardless of message length or bus frequency, causing unnecessary
> delays on error paths.
>
> Compute the timeout dynamically from message length and bus frequency
> with a 10x safety margin over the theoretical wire time and a 300ms
> floor. For GPI multi-descriptor transfers, use the maximum message
> length across all queued messages as the per-completion timeout.
>
> Signed-off-by: Aniket Randive <aniket.randive@oss.qualcomm.com>
> ---
> arch/arm64/configs/defconfig | 54 +++---------------------------
> drivers/i2c/busses/i2c-qcom-geni.c | 37 +++++++++++++++-----
> 2 files changed, 33 insertions(+), 58 deletions(-)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index faf146441f97..841108ae2d01 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -32,7 +32,6 @@ CONFIG_KALLSYMS_ALL=y
> CONFIG_PROFILING=y
> CONFIG_KEXEC=y
> CONFIG_KEXEC_FILE=y
> -CONFIG_CRASH_DUMP=y
Irrelevant patch change. And not really correct - you base this on some
old tree.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-06 5:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-05 13:46 [PATCH v1] i2c: qcom-geni: Add dynamic transfer timeout based on transfer length and frequency Aniket Randive
2026-07-06 5:58 ` Krzysztof Kozlowski [this message]
2026-07-06 8:22 ` Aniket RANDIVE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1edb643c-1d09-4ad8-97df-66c86e6123c5@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=aniket.randive@oss.qualcomm.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mukesh.savaliya@oss.qualcomm.com \
--cc=naresh.maramaina@oss.qualcomm.com \
--cc=sumit.semwal@linaro.org \
--cc=viken.dadhaniya@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox