public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org,
	repvik-ifZ3rLY3rVnQT0dZR+AlfA@public.gmane.org,
	hvr-mXXj517/zsQ@public.gmane.org,
	i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org,
	timtimred-f/KTTADhmRsdnm+yROfE0A@public.gmane.org,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org
Subject: Re: [PATCH 1/2] Add support for the S-35390A RTC chip.
Date: Fri, 4 Jan 2008 13:42:05 -0800	[thread overview]
Message-ID: <200801041342.05612.david-b@pacbell.net> (raw)
In-Reply-To: <20080104210605.05e1a0d4-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>

On Friday 04 January 2008, Jean Delvare wrote:
> > +     if (buf[0] & S35390A_FLAG_24H)
> > +             s35390a->twentyfourhour = 1;
> > +     else
> > +             s35390a->twentyfourhour = 0;
> 
> Wouldn't it be more efficient to just force 24h mode here?

Maybe, but that would make trouble on multi-master systems where
the other masters assume this stays initialized.  Also, many
RTCs can't change that mode easily ... so it should be done only
when (re)initializing after e.g. an oscillator failure or loss
of the backup power supply.

- Dave
 

  parent reply	other threads:[~2008-01-04 21:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1197751376-9767-1-git-send-email-byron.bbradley@gmail.com>
     [not found] ` <1197751376-9767-1-git-send-email-byron.bbradley-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-01-04 18:36   ` [PATCH 0/2] Add support for the S-35390A RTC chip Jean Delvare
     [not found] ` <1197751376-9767-2-git-send-email-byron.bbradley@gmail.com>
     [not found]   ` <1197751376-9767-2-git-send-email-byron.bbradley-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-01-04 20:06     ` [PATCH 1/2] " Jean Delvare
     [not found]       ` <20080104210605.05e1a0d4-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-01-04 21:42         ` David Brownell [this message]
2008-01-04 22:46         ` Byron Bradley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801041342.05612.david-b@pacbell.net \
    --to=david-b-ybekhbn/0ldr7s880joybq@public.gmane.org \
    --cc=a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=hvr-mXXj517/zsQ@public.gmane.org \
    --cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
    --cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
    --cc=repvik-ifZ3rLY3rVnQT0dZR+AlfA@public.gmane.org \
    --cc=timtimred-f/KTTADhmRsdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox