Re: [PATCH 0/2] Add support for the S-35390A RTC chip.

Jean Delvare
2008-01-04T18:36:21Z

Hi Byron,

On Sat, 15 Dec 2007 20:42:54 +0000, Byron Bradley wrote:
> These patches provide support the S-35390A RTC chip as used in the
> QNAP TS-109/TS-209 NAS devices. Along with a change from Andrew Morton
> this has already been accepted into the -mm tree but it was suggested
> that I send it to this list for an I2C review.
>
> This chip is special in that the first 4-bits of the address are fixed
> to 0xc and the next 3-bits are used as a command so it takes up 8 addresses
> on the I2C bus.

What a weird design :(

> 0001 Add support for the S-35390A RTC chip.
> 0002 rtc-add-support-for-the-s-35390a-rtc-chip-fix
> Written by Andrew Morton this replaces my bit-reversing function
> with bitrev8().

Given that your original patch isn't merged in git yet, the preferred
approach is to merge the fixes in your patch before you resubmit it.
This makes further reviews easier.

--
Jean Delvare