Re: [PATCH 1/2] Add support for the S-35390A RTC chip.

David Brownell
2008-01-04T21:42:05Z

On Friday 04 January 2008, Jean Delvare wrote:
> > +     if (buf[0] & S35390A_FLAG_24H)
> > +             s35390a->twentyfourhour = 1;
> > +     else
> > +             s35390a->twentyfourhour = 0;
>
> Wouldn't it be more efficient to just force 24h mode here?

Maybe, but that would make trouble on multi-master systems where
the other masters assume this stays initialized. Also, many
RTCs can't change that mode easily ... so it should be done only
when (re)initializing after e.g. an oscillator failure or loss
of the backup power supply.

- Dave