From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: Byron Bradley <byron.bbradley-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCH] Add support for the S-35390A RTC chip.
Date: Sun, 6 Jan 2008 14:25:37 -0800 [thread overview]
Message-ID: <200801061425.38412.david-b@pacbell.net> (raw)
In-Reply-To: <57e2b00801061411g4d5280deg4bc9f8dc4c8bce8b-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Sunday 06 January 2008, Byron Bradley wrote:
> David, the ENOCSI comment probably applies to your at24 eeprom driver
> too. I was wondering why that error code was chosen since other than
> "No CSI structure available" I couldn't find anything about it.
It was chosen for its uniqueness ... ideally each fault path has its
own fault code and (possibly debug-only) diagnostic. When you get
a fault code from a driver, and there's only one place that's used,
it's a lot easier to know what went wrong than if the fault code is
(over)used in many places.
In fact it's common practice to adopt subsystem-specific conventions
about what a given errno value indicates. Otherwise, almost every
fault observed would map to a small handful ... making them useless
for fault recovery logic, and at best problematic in terms of any
diagnostic utility.
- Dave
next prev parent reply other threads:[~2008-01-06 22:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-05 22:58 [PATCH] Add support for the S-35390A RTC chip Byron Bradley
[not found] ` <1199573894-9189-1-git-send-email-byron.bbradley-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-01-06 18:01 ` Jean Delvare
[not found] ` <20080106190100.5e7b6be9-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-01-06 22:11 ` Byron Bradley
[not found] ` <57e2b00801061411g4d5280deg4bc9f8dc4c8bce8b-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-01-06 22:25 ` David Brownell [this message]
[not found] ` <200801061425.38412.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-01-08 12:07 ` Jean Delvare
[not found] ` <20080108130712.50613b02-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-01-08 12:39 ` David Brownell
[not found] ` <200801080439.28135.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-01-08 13:01 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801061425.38412.david-b@pacbell.net \
--to=david-b-ybekhbn/0ldr7s880joybq@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=byron.bbradley-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox