From: Greg KH <gregkh-l3A5Bk7waGM@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Linux I2C <i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>
Subject: Re: [PATCH] i2c: Let the user specify PCI driver data through new_id
Date: Thu, 17 Jan 2008 10:01:39 -0800 [thread overview]
Message-ID: <20080117180139.GC6996@suse.de> (raw)
In-Reply-To: <20080117140937.6fd37183-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
On Thu, Jan 17, 2008 at 02:09:37PM +0100, Jean Delvare wrote:
> The i2c-amd756 and i2c-viapro drivers make use of the driver_data
> field of the PCI device ID. When adding device IDs dynamically (by
> writing to the new_id sysfs file) you cannot set the value of this
> field by default. It has to be allowed explicitly. Do that, and
> check the value so that the user can't crash the kernel accidentally.
>
> Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Acked-by: Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org>
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
prev parent reply other threads:[~2008-01-17 18:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-17 13:09 [PATCH] i2c: Let the user specify PCI driver data through new_id Jean Delvare
[not found] ` <20080117140937.6fd37183-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-01-17 18:01 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080117180139.GC6996@suse.de \
--to=gregkh-l3a5bk7wagm@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox