From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Manuel Lauss <mano-nEyxjcs6f3Vin2gBucwGBecsttgLyre6@public.gmane.org>
Cc: cd-8pe3aW1LYQuzSzjNS9e3XA@public.gmane.org,
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCH] i2c-au1550: convert to platform driver
Date: Fri, 18 Jan 2008 13:38:59 +0100 [thread overview]
Message-ID: <20080118133859.0271541c@hyperion.delvare> (raw)
In-Reply-To: <20080118090913.GA19940-nEyxjcs6f3Vin2gBucwGBecsttgLyre6@public.gmane.org>
Hi Manuel,
On Fri, 18 Jan 2008 10:09:13 +0100, Manuel Lauss wrote:
> Hi Jean,
>
> On Sat, Oct 27, 2007 at 08:05:21PM +0200, Jean Delvare wrote:
> >
> > > +/* All Alchemy demoboards with I2C have this #define in their headers */
> > > +#ifdef SMBUS_PSC_BASE
> > > +static struct resource pbdb_smbus_resources[] = {
> > > + {
> > > + .start = SMBUS_PSC_BASE,
> > > + .end = SMBUS_PSC_BASE + 0x24 - 1,
> > > + .flags = IORESOURCE_MEM,
> >
> > Aren't resources supposed to have a name, so that they are displayed
> > properly in /proc/iomem)?
>
> it looks okay to me the way it is, so I didn't change it:
>
> b1a00000-b1a00023 : au1xpsc_smbus.0
> b1a00000-b1a00023 : au1xpsc_smbus
Ah, OK, I didn't know that. I guess that the driver core can give
default names to resources that have no name at registration time.
Thanks for the info!
--
Jean Delvare
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
next prev parent reply other threads:[~2008-01-18 12:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071006161606.GB9270@roarinelk.homelinux.net>
[not found] ` <20071027200521.3d800147@hyperion.delvare>
[not found] ` <20071027200521.3d800147-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-01-17 15:59 ` [PATCH] i2c-au1550: convert to platform driver Jean Delvare
[not found] ` <20080117165916.5171348d-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-01-17 16:38 ` Manuel Lauss
2008-01-18 9:09 ` Manuel Lauss
[not found] ` <20080118090913.GA19940-nEyxjcs6f3Vin2gBucwGBecsttgLyre6@public.gmane.org>
2008-01-18 12:38 ` Jean Delvare [this message]
2008-01-18 9:37 ` Manuel Lauss
2008-01-18 9:53 ` Manuel Lauss
[not found] ` <20080118095320.GA20550-nEyxjcs6f3Vin2gBucwGBecsttgLyre6@public.gmane.org>
2008-01-18 18:55 ` Jean Delvare
[not found] ` <20080118195546.1d3818a9-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-01-21 8:47 ` [PATCH] i2c-au1550: convert to platform driver #4 Manuel Lauss
[not found] ` <20080121084706.GA12519-nEyxjcs6f3Vin2gBucwGBecsttgLyre6@public.gmane.org>
2008-01-21 12:30 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080118133859.0271541c@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=cd-8pe3aW1LYQuzSzjNS9e3XA@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=mano-nEyxjcs6f3Vin2gBucwGBecsttgLyre6@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox