public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Jon Smirl <jonsmirl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Linux I2C <i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>
Subject: Re: i2c_adapter.class and new style drivers
Date: Tue, 22 Jan 2008 15:23:47 +0100	[thread overview]
Message-ID: <20080122152347.1ebd0f4c@hyperion.delvare> (raw)
In-Reply-To: <9e4733910801211549v74ca13c4ya07179d36b35bff0-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi Jon,

On Mon, 21 Jan 2008 18:49:34 -0500, Jon Smirl wrote:
> Is i2c_adapter.class relevant anymore with new style drivers?

No, it's not. The class is meant to limit the probing scope of
legacy i2c chip drivers. New-style i2c chip drivers shouldn't care.

Note that these classes aren't going away anytime soon though: some
chip types just have to be probed (e.g. hardware monitoring chips or
EEPROMs on PC motherboards) so even if these drivers are eventually
converted to new-style i2c chip drivers, some (possibly external)
probing will still be necessary, and the class will be there to limit
the scope of this probing.

> On 1/2/08, Jochen Friedrich <jochen-NIgtFMG+Po8@public.gmane.org> wrote:
> > IMHO, there should be a node attribute to override
> > i2c_adapter.class. Legacy i2c drivers (in particular v4l and dvb
> > drivers) use this class to decide which adapter to bind to.
> > dbox2 needs I2C_CLASS_TV_DIGITAL (4).

I am fine with a node attribute allowing control of this attribute,
that could be handy for testing and debugging purposes. If someone
submits a patch implementing this, I'll review and merge it.

-- 
Jean Delvare

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

  parent reply	other threads:[~2008-01-22 14:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-21 23:49 i2c_adapter.class and new style drivers Jon Smirl
     [not found] ` <9e4733910801211549v74ca13c4ya07179d36b35bff0-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-01-22 11:15   ` Jochen Friedrich
2008-01-22 14:23   ` Jean Delvare [this message]
     [not found]     ` <20080122152347.1ebd0f4c-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-01-22 15:55       ` Jon Smirl
     [not found]         ` <9e4733910801220755j45b4c48m467679ebdd2ef911-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-01-22 19:25           ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080122152347.1ebd0f4c@hyperion.delvare \
    --to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
    --cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
    --cc=jonsmirl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox