From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: Guennadi Liakhovetski
<g.liakhovetski-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: video4linux-list-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCH 3/3] Add support for PCA953[4-8] I2C GPIO extenders to the pca953x driver
Date: Thu, 31 Jan 2008 13:20:57 -0800 [thread overview]
Message-ID: <200801311320.57437.david-b@pacbell.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0801311500240.8478-0199iw4Nj15frtckUFj5Ag@public.gmane.org>
On Thursday 31 January 2008, Guennadi Liakhovetski wrote:
> +/* This is only temporary - should go with 2.6.26. Only introduced now
> + * to avoid a sequence of strcmp() calls and just compare in a loop */
> +struct pca953x_desc {
> + unsigned int gpios;
> + char *name;
> +};
This is a bit sub-optimal; if it were the same as i2c_device_id then
less code would need to change later. So I'll probably tweak that bit
before sending it on.
Otherwise, fine ... thanks!
- Dave
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
next prev parent reply other threads:[~2008-01-31 21:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 14:04 [PATCH 1/3] Prepare to extend pca9539 to support more chips - rename files Guennadi Liakhovetski
[not found] ` <Pine.LNX.4.64.0801311453470.8478-0199iw4Nj15frtckUFj5Ag@public.gmane.org>
2008-01-31 14:04 ` [PATCH 2/3] Second stage extending the pca953x GPIO driver - change Kconfig, "sed" files Guennadi Liakhovetski
[not found] ` <Pine.LNX.4.64.0801311456280.8478-0199iw4Nj15frtckUFj5Ag@public.gmane.org>
2008-01-31 21:25 ` David Brownell
2008-01-31 21:01 ` [PATCH 1/3] Prepare to extend pca9539 to support more chips - rename files David Brownell
2008-01-31 22:06 ` Guennadi Liakhovetski
[not found] ` <Pine.LNX.4.64.0801312303270.3704-0199iw4Nj15frtckUFj5Ag@public.gmane.org>
2008-01-31 23:50 ` David Brownell
2008-01-31 14:04 ` [PATCH 3/3] Add support for PCA953[4-8] I2C GPIO extenders to the pca953x driver Guennadi Liakhovetski
[not found] ` <Pine.LNX.4.64.0801311500240.8478-0199iw4Nj15frtckUFj5Ag@public.gmane.org>
2008-01-31 21:20 ` David Brownell [this message]
2008-01-31 22:13 ` Guennadi Liakhovetski
[not found] ` <Pine.LNX.4.64.0801312308110.3704-0199iw4Nj15frtckUFj5Ag@public.gmane.org>
2008-01-31 23:35 ` David Brownell
2008-02-01 10:57 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801311320.57437.david-b@pacbell.net \
--to=david-b-ybekhbn/0ldr7s880joybq@public.gmane.org \
--cc=g.liakhovetski-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=video4linux-list-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox