From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Tobias Klauser <tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
Cc: trivial-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCH] i2c: Storage class should be before const qualifier
Date: Sun, 17 Feb 2008 19:49:19 +0100 [thread overview]
Message-ID: <20080217194919.7aacb0fa@hyperion.delvare> (raw)
In-Reply-To: <20080217143907.GA9270-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
Hi Tobias,
On Sun, 17 Feb 2008 15:39:07 +0100, Tobias Klauser wrote:
> The C99 specification states in section 6.11.5:
>
> The placement of a storage-class specifier other than at the
> beginning of the declaration specifiers in a declaration is an
> obsolescent feature.
>
> Signed-off-by: Tobias Klauser <tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
> ---
> drivers/i2c/busses/i2c-pmcmsp.c | 4 ++--
> include/linux/i2c.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-pmcmsp.c b/drivers/i2c/busses/i2c-pmcmsp.c
> index be99c02..b03af56 100644
> --- a/drivers/i2c/busses/i2c-pmcmsp.c
> +++ b/drivers/i2c/busses/i2c-pmcmsp.c
> @@ -122,7 +122,7 @@ struct pmcmsptwi_data {
> };
>
> /* The default settings */
> -const static struct pmcmsptwi_clockcfg pmcmsptwi_defclockcfg = {
> +static const struct pmcmsptwi_clockcfg pmcmsptwi_defclockcfg = {
> .standard = {
> .filter = 0x3,
> .clock = 0x1f,
> @@ -133,7 +133,7 @@ const static struct pmcmsptwi_clockcfg pmcmsptwi_defclockcfg = {
> },
> };
>
> -const static struct pmcmsptwi_cfg pmcmsptwi_defcfg = {
> +static const struct pmcmsptwi_cfg pmcmsptwi_defcfg = {
> .arbf = 0x03,
> .nak = 0x03,
> .add10 = 0x00,
> diff --git a/include/linux/i2c.h b/include/linux/i2c.h
> index 76014f8..2d1c608 100644
> --- a/include/linux/i2c.h
> +++ b/include/linux/i2c.h
> @@ -598,7 +598,7 @@ I2C_CLIENT_MODULE_PARM(probe, "List of adapter,address pairs to scan " \
> "additionally"); \
> I2C_CLIENT_MODULE_PARM(ignore, "List of adapter,address pairs not to " \
> "scan"); \
> -const static struct i2c_client_address_data addr_data = { \
> +static const struct i2c_client_address_data addr_data = { \
> .normal_i2c = normal_i2c, \
> .probe = probe, \
> .ignore = ignore, \
Applied, thanks.
--
Jean Delvare
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
prev parent reply other threads:[~2008-02-17 18:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-17 14:39 [PATCH] i2c: Storage class should be before const qualifier Tobias Klauser
[not found] ` <20080217143907.GA9270-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
2008-02-17 18:49 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080217194919.7aacb0fa@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org \
--cc=trivial-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox