From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCHv2 3/3] Add platform driver on top of the new
Date: Mon, 10 Mar 2008 09:02:51 -0800 [thread overview]
Message-ID: <200803101002.52153.david-b@pacbell.net> (raw)
> +#ifdef CONFIG_GENERIC_GPIO
> +#include <asm/gpio.h>
> +#endif
You should #include <linux/gpio.h> now and avoid a lot
of this #ifdeffery ... which is something I think you'd
be told by running checkpatch.pl on 2.6.25-rc5, as well
as most RC4 kernels.
> + /* Use NO_GPIO when this macro is in mainline */
I hope you mean gpio_is_valid() instead... that's in MM,
but not yet mainline (except when <linux/gpio.h> is all
stubs).
- Dave
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
next reply other threads:[~2008-03-10 17:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-10 17:02 David Brownell [this message]
[not found] ` <200803101002.52153.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-03-14 10:51 ` [PATCHv2 3/3] Add platform driver on top of the new Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803101002.52153.david-b@pacbell.net \
--to=david-b-ybekhbn/0ldr7s880joybq@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox