From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH 0/6] Blackfin I2C TWI driver updates Date: Thu, 13 Mar 2008 13:03:32 +0100 Message-ID: <20080313130332.46af8228@hyperion.delvare> References: <1205479360-25240-1-git-send-email-cooloney@kernel.org> <20080312193718.1aa86caf@hyperion.delvare> <386072610803121907y499903ban37456d06d36a07a8@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <386072610803121907y499903ban37456d06d36a07a8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org Errors-To: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org To: Bryan Wu Cc: i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Thu, 13 Mar 2008 10:07:07 +0800, Bryan Wu wrote: > Actually, I plan to send out these for 2.6.26 at first. But found > following BF54x compiling error: > > -- > drivers/i2c/busses/i2c-bfin-twi.c: In function 'bfin_twi_handle_interrupt': > drivers/i2c/busses/i2c-bfin-twi.c:67: error: implicit declaration of > function 'bfin_read_TWI_INT_STAT' > drivers/i2c/busses/i2c-bfin-twi.c:68: error: implicit declaration of > function 'bfin_read_TWI_MASTER_STAT' > drivers/i2c/busses/i2c-bfin-twi.c:73: error: implicit declaration of > function 'bfin_write_TWI_XMT_DATA8' > drivers/i2c/busses/i2c-bfin-twi.c:80: error: implicit declaration of > function 'bfin_write_TWI_MASTER_CTL' > drivers/i2c/busses/i2c-bfin-twi.c:80: error: implicit declaration of > function 'bfin_read_TWI_MASTER_CTL' > drivers/i2c/busses/i2c-bfin-twi.c:87: error: implicit declaration of > function 'bfin_write_TWI_INT_STAT' > drivers/i2c/busses/i2c-bfin-twi.c:93: error: implicit declaration of > function 'bfin_read_TWI_RCV_DATA8' > drivers/i2c/busses/i2c-bfin-twi.c:118: error: implicit declaration of > function 'bfin_write_TWI_INT_MASK' > drivers/i2c/busses/i2c-bfin-twi.c:119: error: implicit declaration of > function 'bfin_write_TWI_MASTER_STAT' > drivers/i2c/busses/i2c-bfin-twi.c: In function 'bfin_twi_master_xfer': > drivers/i2c/busses/i2c-bfin-twi.c:227: error: implicit declaration of > function 'bfin_read_TWI_CONTROL' > drivers/i2c/busses/i2c-bfin-twi.c:251: error: implicit declaration of > function 'bfin_write_TWI_MASTER_ADDR' > drivers/i2c/busses/i2c-bfin-twi.c:256: error: implicit declaration of > function 'bfin_write_TWI_FIFO_CTL' > drivers/i2c/busses/i2c-bfin-twi.c: In function 'i2c_bfin_twi_suspend': > drivers/i2c/busses/i2c-bfin-twi.c:520: error: implicit declaration of > function 'bfin_write_TWI_CONTROL' > drivers/i2c/busses/i2c-bfin-twi.c: In function 'i2c_bfin_twi_probe': > drivers/i2c/busses/i2c-bfin-twi.c:545: error: 'IRQ_TWI' undeclared > (first use in this function) > drivers/i2c/busses/i2c-bfin-twi.c:545: error: (Each undeclared > identifier is reported only once > drivers/i2c/busses/i2c-bfin-twi.c:545: error: for each function it appears in.) > drivers/i2c/busses/i2c-bfin-twi.c:572: error: implicit declaration of > function 'bfin_write_TWI_CLKDIV' > make[3]: *** [drivers/i2c/busses/i2c-bfin-twi.o] Error 1 > make[2]: *** [drivers/i2c/busses] Error 2 > make[1]: *** [drivers/i2c] Error 2 > make: *** [drivers] Error 2 > -- > > But as you said, it is -rc5 now. If these can be merged in 2.6.26, it > is OK for me. Maybe you can provide a fix for just this build problem? This I would possibly push into 2.6.25, and then the rest of your updates go on top of it for 2.6.26. -- Jean Delvare _______________________________________________ i2c mailing list i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org http://lists.lm-sensors.org/mailman/listinfo/i2c