Re: [PATCH 0/6] Blackfin I2C TWI driver updates

Jean Delvare
2008-03-13T12:03:32Z

On Thu, 13 Mar 2008 10:07:07 +0800, Bryan Wu wrote:
> Actually, I plan to send out these for 2.6.26 at first. But found
> following BF54x compiling error:
>
> --
> drivers/i2c/busses/i2c-bfin-twi.c: In function 'bfin_twi_handle_interrupt':
> drivers/i2c/busses/i2c-bfin-twi.c:67: error: implicit declaration of
> function 'bfin_read_TWI_INT_STAT'
> drivers/i2c/busses/i2c-bfin-twi.c:68: error: implicit declaration of
> function 'bfin_read_TWI_MASTER_STAT'
> drivers/i2c/busses/i2c-bfin-twi.c:73: error: implicit declaration of
> function 'bfin_write_TWI_XMT_DATA8'
> drivers/i2c/busses/i2c-bfin-twi.c:80: error: implicit declaration of
> function 'bfin_write_TWI_MASTER_CTL'
> drivers/i2c/busses/i2c-bfin-twi.c:80: error: implicit declaration of
> function 'bfin_read_TWI_MASTER_CTL'
> drivers/i2c/busses/i2c-bfin-twi.c:87: error: implicit declaration of
> function 'bfin_write_TWI_INT_STAT'
> drivers/i2c/busses/i2c-bfin-twi.c:93: error: implicit declaration of
> function 'bfin_read_TWI_RCV_DATA8'
> drivers/i2c/busses/i2c-bfin-twi.c:118: error: implicit declaration of
> function 'bfin_write_TWI_INT_MASK'
> drivers/i2c/busses/i2c-bfin-twi.c:119: error: implicit declaration of
> function 'bfin_write_TWI_MASTER_STAT'
> drivers/i2c/busses/i2c-bfin-twi.c: In function 'bfin_twi_master_xfer':
> drivers/i2c/busses/i2c-bfin-twi.c:227: error: implicit declaration of
> function 'bfin_read_TWI_CONTROL'
> drivers/i2c/busses/i2c-bfin-twi.c:251: error: implicit declaration of
> function 'bfin_write_TWI_MASTER_ADDR'
> drivers/i2c/busses/i2c-bfin-twi.c:256: error: implicit declaration of
> function 'bfin_write_TWI_FIFO_CTL'
> drivers/i2c/busses/i2c-bfin-twi.c: In function 'i2c_bfin_twi_suspend':
> drivers/i2c/busses/i2c-bfin-twi.c:520: error: implicit declaration of
> function 'bfin_write_TWI_CONTROL'
> drivers/i2c/busses/i2c-bfin-twi.c: In function 'i2c_bfin_twi_probe':
> drivers/i2c/busses/i2c-bfin-twi.c:545: error: 'IRQ_TWI' undeclared
> (first use in this function)
> drivers/i2c/busses/i2c-bfin-twi.c:545: error: (Each undeclared
> identifier is reported only once
> drivers/i2c/busses/i2c-bfin-twi.c:545: error: for each function it appears in.)
> drivers/i2c/busses/i2c-bfin-twi.c:572: error: implicit declaration of
> function 'bfin_write_TWI_CLKDIV'
> make[3]: *** [drivers/i2c/busses/i2c-bfin-twi.o] Error 1
> make[2]: *** [drivers/i2c/busses] Error 2
> make[1]: *** [drivers/i2c] Error 2
> make: *** [drivers] Error 2
> --
>
> But as you said, it is -rc5 now. If these can be merged in 2.6.26, it
> is OK for me.

Maybe you can provide a fix for just this build problem? This I would
possibly push into 2.6.25, and then the rest of your updates go on top
of it for 2.6.26.

--
Jean Delvare