Re: [PATCH 0/6] Blackfin I2C TWI driver updates

Bryan Wu
2008-03-13T07:50:59Z

On Thu, Mar 13, 2008 at 1:43 PM, Kalle Pokki <kalle.pokki-jgfpPLbCha8@public.gmane.org> wrote:
> On Thu, 13 Mar 2008, Bryan Wu wrote:
>
> > I understand. It is too late.
> >
> > Actually, I plan to send out these for 2.6.26 at first. But found
> > following BF54x compiling error:
>
> Please post a fix for the compile error in 2.6.25. As Jean pointed out,
> build and bug fixes should always be sent upstream asap, without waiting
> for the next merge window.
>

[PATCH 2/6] is to fix this compile error bug.
So Jean, could you please just merge
patch 1/6 and patch 2/6 for 2.6.25, while others for 2.6.26?

> Although I don't have a BF54x platform I have at times run into a few
> other build failures with BF533 and BF537. These are the most irritating
> bugs for other people to discover in the final releases since they should
> be the simplest to find and fix, often leaving the impression the code
> wasn't even built before submitting. Of course, in reality we cannot
> always build for every platform.
>

Actually, we got a daily build machine try to build upstream mainline
git-tree, -mm tree
and other source tree with all Blackfin platform configuration. This
BF54x compile error was
found by this. We will try to fix it before stable version out.

> Actually, patch 1/6 seems to be a real bug fix. In the current code the
> i2c-bfin-twi master transmit is broken for all drivers requiring a restart
> condition.
>

So patch 1/6 and patch 2/6 is ready for 2.6.25, don't they?

Thanks
Regards,
-Bryan