Re: [PATCH 0/6] Blackfin I2C TWI driver updates

Kalle Pokki
2008-03-13T05:43:30Z

On Thu, 13 Mar 2008, Bryan Wu wrote:

> I understand. It is too late.
>
> Actually, I plan to send out these for 2.6.26 at first. But found
> following BF54x compiling error:

Please post a fix for the compile error in 2.6.25. As Jean pointed out,
build and bug fixes should always be sent upstream asap, without waiting
for the next merge window.

Although I don't have a BF54x platform I have at times run into a few
other build failures with BF533 and BF537. These are the most irritating
bugs for other people to discover in the final releases since they should
be the simplest to find and fix, often leaving the impression the code
wasn't even built before submitting. Of course, in reality we cannot
always build for every platform.

Actually, patch 1/6 seems to be a real bug fix. In the current code the
i2c-bfin-twi master transmit is broken for all drivers requiring a restart
condition.