From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Darius <augulis.darius-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org,
linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org
Subject: Re: [PATCH] I2C driver for IMX
Date: Thu, 13 Mar 2008 22:05:46 +0100 [thread overview]
Message-ID: <20080313210546.GA4483@pengutronix.de> (raw)
In-Reply-To: <frbjjv$ndk$1@ger.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 1270 bytes --]
On Thu, Mar 13, 2008 at 06:07:45PM +0200, Darius wrote:
Hello,
(I know I am myself quite new here. I don't want to boast, just trying
to be a little bit helpful.)
I found some things concerning the formal side:
> + * History: 2002/2/07 use msgs[]
I have been told here that histories are not wanted as they are achieved
through git.
> +static struct platform_driver i2c_imx_driver = {
> + .probe = i2c_imx_probe,
> + .remove = i2c_imx_remove,
> + .driver = {
> + .name = DRIVER_NAME,
> + .owner = THIS_MODULE,
Indentation seems wrong here and in some other places...
> +struct imx_i2c_struct {
> + struct i2c_adapter adapter;
> + struct resource *res;
> + void __iomem *base;
...like here and so on.
> + #ifdef CONFIG_I2C_DEBUG_BUS
> + printk("I2C: <i2c_imx_bus_busy>\n");
> + #endif
Maybe you can define a debug-printing-macro that only prints when
DEBUG_BUS is set and is simply empty when it is unset? This should make
the code more readable, I think (or use pr_debug).
> + // chech or i2c bus is not busy
CodingStyle suggests not using //.
All the best,
Wolfram
--
Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de
Pengutronix - Linux Solutions for Science and Industry
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
next prev parent reply other threads:[~2008-03-13 21:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 16:07 [PATCH] I2C driver for IMX Darius
2008-03-13 21:05 ` Wolfram Sang [this message]
[not found] ` <20080313210546.GA4483-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2008-03-14 7:26 ` Darius
2008-03-14 8:57 ` Wolfram Sang
2008-03-14 7:37 ` Lothar Waßmann
2008-03-14 10:00 ` Andrew Dyer
[not found] ` <c166aa9f0803140300n75f6790enee3f28bdebeba945-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-03-14 10:13 ` Darius
2008-03-14 18:03 ` [i2c] " Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080313210546.GA4483@pengutronix.de \
--to=w.sang-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=augulis.darius-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox