From: Jean Delvare <khali@linux-fr.org>
To: Darius <augulis.darius@gmail.com>
Cc: i2c@lm-sensors.org, linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [i2c] [PATCH] I2C driver for IMX
Date: Fri, 14 Mar 2008 19:03:18 +0100 [thread overview]
Message-ID: <20080314190318.732d84e2@hyperion.delvare> (raw)
In-Reply-To: <frbjjv$ndk$1@ger.gmane.org>
Hi Darius,
On Thu, 13 Mar 2008 18:07:45 +0200, Darius wrote:
> Almost written from scratch - only small piece of code leaved from old
> driver, witch never was originally in vanilla kernel.
> SMB is NOT supported currently.
Assuming that you mean SMBus, it is in fact almost supported, because
i2c-core can emulate most of SMBus over I2C. Just add
I2C_FUNC_SMBUS_EMUL to i2c_imx_func() and you're done. If the device
doesn't support zero-byte messages, you might have to remove
I2C_FUNC_SMBUS_QUICK but that's about it.
> Tested on the MXLADS v2.0 board with i2c client driver (driver for
> NT7651 LCD controller). All works fine, stable.
You really need to read Documentation/CodingStyle and adjust your code
accordingly before I will consider merging your patch.
scripts/checkpatch.pl is your friend too.
--
Jean Delvare
-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php
prev parent reply other threads:[~2008-03-14 18:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 16:07 [PATCH] I2C driver for IMX Darius
2008-03-13 21:05 ` Wolfram Sang
[not found] ` <20080313210546.GA4483-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2008-03-14 7:26 ` Darius
2008-03-14 8:57 ` Wolfram Sang
2008-03-14 7:37 ` Lothar Waßmann
2008-03-14 10:00 ` Andrew Dyer
[not found] ` <c166aa9f0803140300n75f6790enee3f28bdebeba945-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-03-14 10:13 ` Darius
2008-03-14 18:03 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080314190318.732d84e2@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=augulis.darius@gmail.com \
--cc=i2c@lm-sensors.org \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox