From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCHv2 3/3] Add platform driver on top of the new pca-algorithm Date: Sun, 16 Mar 2008 16:44:57 +0100 Message-ID: <20080316164457.19157e0c@hyperion.delvare> References: <20080308111337.440a7c83@hyperion.delvare> <20080310112640.GB12128@pengutronix.de> <20080310223116.73277c4f@hyperion.delvare> <20080314145010.GA28612@pengutronix.de> <20080314194628.07630698@hyperion.delvare> <20080316142834.GA4485@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080316142834.GA4485-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org Errors-To: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org To: Wolfram Sang Cc: i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Sun, 16 Mar 2008 15:28:34 +0100, Wolfram Sang wrote: > On Fri, Mar 14, 2008 at 07:46:28PM +0100, Jean Delvare wrote: > > > > + /* Use gpio_is_valid() when in mainline */ > > > + if (i2c->gpio > -1) > > > + ret = gpio_request(i2c->gpio, i2c->adap.name); > > > + if (ret == 0) { > > > + gpio_direction_output(i2c->gpio, 1); > > > + i2c->algo_data.reset_chip = i2c_pca_pf_resetchip; > > > + } else { > > > + printk(KERN_WARNING "%s: Registering gpio failed!\n", > > > + i2c->adap.name); > > > + i2c->gpio = ret; > > > + } > > > > You're missing curly braces around this block, aren't you? > Holy ..., yes, you are right. This is why I used to have braces even > around single instructions after if. This is, where CodingStyle gives me > most trouble. I can't agree more... This type of warning I am carefully ignoring when checkpatch.pl complains. In many cases, the extra braces don't hurt and protect us against future mistakes. > > The rest looks OK, so I can fix this myself and queue up your patch for > > 2.6.26. > > Ah, finally! \o/ Thanks a _lot_ for your help, I learnt a lot and this > will hopefully show in my next submission :) You're welcome. It has been a pleasure to work with you and I am looking forward to your next submissions! -- Jean Delvare _______________________________________________ i2c mailing list i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org http://lists.lm-sensors.org/mailman/listinfo/i2c