Re: [PATCH] I2C: Fix unhandled fault in i2c-omap controller, take #2

[David Brownell <david-b@pacbell.net>]

On Monday 17 March 2008, Tony Lindgren wrote:
> @@ -360,7 +374,7 @@ omap_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
>         int i;
>         int r;
>  
> -       omap_i2c_enable_clocks(dev);
> +       omap_i2c_unidle(dev);
>  
>         if ((r = omap_i2c_wait_for_bb(dev)) < 0)
>                 goto out;
> @@ -374,7 +388,7 @@ omap_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
>         if (r == 0)
>                 r = num;
>  out:
> -       omap_i2c_disable_clocks(dev);
> +       omap_i2c_idle(dev);
>         return r;
>  }
>  

Wouldn't it be nice -- from a pure power management perspective
of course! -- if more drivers were this careful about idling
their clocks when they have no work to do.  ;)

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html