From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: "ing. Davide Rizzo" <davide-Rm2/HqoNtBE@public.gmane.org>
Cc: i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCH 2.6.24.3] 24xx Eeprom driver
Date: Mon, 17 Mar 2008 10:21:54 +0100 [thread overview]
Message-ID: <20080317092154.GA6159@pengutronix.de> (raw)
In-Reply-To: <47DE2ECB.6050609-Rm2/HqoNtBE@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 1325 bytes --]
Hello Davide,
it was already discussed that writing to EEPROMs will not be included in
the mainline kernel (it creates the possibility to destroy RAM modules).
Besides, your driver uses the old I2C-binding model and other soon
to-be-removed stuff like .id's.
You might also consider using David Brownell's AT24 driver:
http://lists.lm-sensors.org/pipermail/i2c/2007-May/001208.html
(Side note to David: I already worked on adding platform_data, just need
to test it in a quiet minute.)
To all: Surely a lot of people need an eeprom driver with write
capabilities, especially in the embedded world. I think it would be a
good idea to make David's driver more visible. This wheel was probably
reinvented too many times already (we also had a custom driver in our
company). EEPROMs can be nasty, so one central driver would also be very
good to collect all the quirks.
To make a start I would suggest the following:
Give the AT24 driver a repository (my company would provide this, if
wanted/needed). Place a comment in mainline/eeprom.c (and maybe
Kconfig?) that an advanced driver exists at this repository.
Opinions? Especially David?
All the best,
Wolfram
--
Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de
Pengutronix - Linux Solutions for Science and Industry
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
next prev parent reply other threads:[~2008-03-17 9:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-17 8:41 [PATCH 2.6.24.3] 24xx Eeprom driver ing. Davide Rizzo
[not found] ` <47DE2ECB.6050609-Rm2/HqoNtBE@public.gmane.org>
2008-03-17 9:21 ` Wolfram Sang [this message]
[not found] ` <20080317092154.GA6159-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2008-03-17 11:53 ` Jean Delvare
[not found] ` <20080317125350.253cd04a-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-03-17 13:23 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080317092154.GA6159@pengutronix.de \
--to=w.sang-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=davide-Rm2/HqoNtBE@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox