Re: [PATCH] I2C: ISP1301_OMAP: New-style i2c driver updates, part 2

[David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>]

On Sunday 16 March 2008, Felipe Balbi wrote:
> -       if (machine_is_omap_h2()) {
> -               /* full speed signaling by default */
> -               isp1301_set_bits(isp, ISP1301_MODE_CONTROL_1,
> -                       MC1_SPEED_REG);
> -               isp1301_set_bits(isp, ISP1301_MODE_CONTROL_2,
> -                       MC2_SPD_SUSP_CTRL);

Where did this code end up?  ISTR it was required since the
transceiver's reset mode didn't match how this board was wired.

The details of how the transceiver is wired are something that
should go into platform_data for each board, unless there's code
to pull it out of the transceiver configuration register and
then interpret it here (yeech).  This would be at the level of
whether it uses 6-wire, 4-wire, or 3-wire signaling, and a few
more related points...

ISTR the original patch I sent didn't try to do so much, and
left some of the board-specific code.


> -
> -               /* IRQ wired at M14 */
> -               omap_cfg_reg(M14_1510_GPIO2);

I don't recall seeing this pinmu directive move into
the H2 board setup ... or the gpio_request, below.
Only the IRQ setup moved; but IRQ setup presumes the
pin has already been properly set up as a gpio input.

The result would be that this couldn't possibly work.


> -               isp->irq = OMAP_GPIO_IRQ(2);
> -               if (gpio_request(2, "isp1301") == 0)
> -                       gpio_direction_input(2);
> -               isp->irq_type = IRQF_TRIGGER_FALLING;
> -       }



_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c