From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Linux I2C <i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>
Cc: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>,
Jarkko Nikula
<jarkko.nikula-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
Subject: [PATCH] ASoC/TLV320AIC3X: Stop I2C driver ID abuse
Date: Thu, 20 Mar 2008 17:35:50 +0100 [thread overview]
Message-ID: <20080320173550.0c60326c@hyperion.delvare> (raw)
Please stop using random I2C driver IDs.
Also removed a pointless initialization to 0 of a static struct member.
Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Jarkko Nikula <jarkko.nikula-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
---
I will push this to Linus through my i2c tree by the end of the week.
sound/soc/codecs/tlv320aic3x.c | 2 --
1 file changed, 2 deletions(-)
--- linux-2.6.25-rc6.orig/sound/soc/codecs/tlv320aic3x.c 2008-03-20 17:03:40.000000000 +0100
+++ linux-2.6.25-rc6/sound/soc/codecs/tlv320aic3x.c 2008-03-20 17:03:42.000000000 +0100
@@ -1187,10 +1187,8 @@ static struct i2c_driver aic3x_i2c_drive
.name = "aic3x I2C Codec",
.owner = THIS_MODULE,
},
- .id = I2C_DRIVERID_I2CDEV,
.attach_adapter = aic3x_i2c_attach,
.detach_client = aic3x_i2c_detach,
- .command = NULL,
};
static struct i2c_client client_template = {
--
Jean Delvare
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
next reply other threads:[~2008-03-20 16:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 16:35 Jean Delvare [this message]
[not found] ` <20080320173550.0c60326c-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-03-22 9:28 ` [PATCH] ASoC/TLV320AIC3X: Stop I2C driver ID abuse Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080320173550.0c60326c@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=jarkko.nikula-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
--cc=tiwai-l3A5Bk7waGM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox