* [PATCH] ASoC/TLV320AIC3X: Stop I2C driver ID abuse
@ 2008-03-20 16:35 Jean Delvare
[not found] ` <20080320173550.0c60326c-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2008-03-20 16:35 UTC (permalink / raw)
To: Linux I2C; +Cc: Takashi Iwai, Jarkko Nikula
Please stop using random I2C driver IDs.
Also removed a pointless initialization to 0 of a static struct member.
Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Jarkko Nikula <jarkko.nikula-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
---
I will push this to Linus through my i2c tree by the end of the week.
sound/soc/codecs/tlv320aic3x.c | 2 --
1 file changed, 2 deletions(-)
--- linux-2.6.25-rc6.orig/sound/soc/codecs/tlv320aic3x.c 2008-03-20 17:03:40.000000000 +0100
+++ linux-2.6.25-rc6/sound/soc/codecs/tlv320aic3x.c 2008-03-20 17:03:42.000000000 +0100
@@ -1187,10 +1187,8 @@ static struct i2c_driver aic3x_i2c_drive
.name = "aic3x I2C Codec",
.owner = THIS_MODULE,
},
- .id = I2C_DRIVERID_I2CDEV,
.attach_adapter = aic3x_i2c_attach,
.detach_client = aic3x_i2c_detach,
- .command = NULL,
};
static struct i2c_client client_template = {
--
Jean Delvare
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC/TLV320AIC3X: Stop I2C driver ID abuse
[not found] ` <20080320173550.0c60326c-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
@ 2008-03-22 9:28 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2008-03-22 9:28 UTC (permalink / raw)
To: Jean Delvare; +Cc: Jarkko Nikula, Linux I2C
At Thu, 20 Mar 2008 17:35:50 +0100,
Jean Delvare wrote:
>
> Please stop using random I2C driver IDs.
>
> Also removed a pointless initialization to 0 of a static struct member.
>
> Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> Cc: Jarkko Nikula <jarkko.nikula-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
Acked-by: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>
> ---
> I will push this to Linus through my i2c tree by the end of the week.
OK, thanks.
Takashi
>
> sound/soc/codecs/tlv320aic3x.c | 2 --
> 1 file changed, 2 deletions(-)
>
> --- linux-2.6.25-rc6.orig/sound/soc/codecs/tlv320aic3x.c 2008-03-20 17:03:40.000000000 +0100
> +++ linux-2.6.25-rc6/sound/soc/codecs/tlv320aic3x.c 2008-03-20 17:03:42.000000000 +0100
> @@ -1187,10 +1187,8 @@ static struct i2c_driver aic3x_i2c_drive
> .name = "aic3x I2C Codec",
> .owner = THIS_MODULE,
> },
> - .id = I2C_DRIVERID_I2CDEV,
> .attach_adapter = aic3x_i2c_attach,
> .detach_client = aic3x_i2c_detach,
> - .command = NULL,
> };
>
> static struct i2c_client client_template = {
>
>
> --
> Jean Delvare
>
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-22 9:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-20 16:35 [PATCH] ASoC/TLV320AIC3X: Stop I2C driver ID abuse Jean Delvare
[not found] ` <20080320173550.0c60326c-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-03-22 9:28 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox