From: Paul Mundt <lethal@linux-sh.org>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: i2c@lm-sensors.org, khali@linux-fr.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] i2c: SuperH Mobile I2C Bus Controller
Date: Fri, 21 Mar 2008 15:23:12 +0900 [thread overview]
Message-ID: <20080321062312.GA17225@linux-sh.org> (raw)
In-Reply-To: <20080320141840.13560.24850.sendpatchset@rx1.opensource.se>
On Thu, Mar 20, 2008 at 11:18:40PM +0900, Magnus Damm wrote:
> +static void sh_mobile_i2c_setup_channel(struct platform_device *dev)
> +{
> + struct sh_mobile_i2c_data *pd = platform_get_drvdata(dev);
> + unsigned long peripheral_clk = CONFIG_SH_PCLK_FREQ;
> + u_int32_t num;
> + u_int32_t denom;
> + u_int32_t tmp;
> +
Use clk_get() and friends here for the module clock. This should
absolutely not be hardcoded, especially as it can be scaled by the clock
framework, and the i2c clock will need to rebalance itself to account for
that. Any driver that references CONFIG_SH_PCLK_FREQ is utterly broken.
next prev parent reply other threads:[~2008-03-21 6:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 14:18 [PATCH] i2c: SuperH Mobile I2C Bus Controller Magnus Damm
2008-03-21 6:23 ` Paul Mundt [this message]
2008-03-21 8:14 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080321062312.GA17225@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=i2c@lm-sensors.org \
--cc=khali@linux-fr.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox