[PATCH] New VID/PID pair for i2c-tiny-usb

[PATCH] New VID/PID pair for i2c-tiny-usb

[Till Harbaum / Lists]

I have recently bought some USB PIDs from EZPrototypes for my USB projects
and one will be for the i2c-tiny-usb. I have not yet started to use the new 
one in the official i2c-tiny-usb firmware since i think it makes sense to get 
the change into the kernel before releasing a modified firmware.

This patch adds support for the EZPrototypes USB vid/pid pair used in later
i2c-tiny-usb firmware versions (avrusb v1.06 and up, usbtiny v2.06 and up).

Signed-off-by: Till Harbaum <Till-zicpKgigMvpAfugRpC6u6w@public.gmane.org>

--- linux-2.6.24.3.orig/drivers/i2c/busses/i2c-tiny-usb.c	2008-02-26 
01:20:20.000000000 +0100
+++ linux-2.6.24.3/drivers/i2c/busses/i2c-tiny-usb.c	2008-03-24 
10:27:13.000000000 +0100
@@ -131,11 +131,13 @@
 
 /* ----- begin of usb layer ---------------------------------------------- */
 
-/* The usb i2c interface uses a vid/pid pair donated by */
-/* Future Technology Devices International Ltd. */
+/* Initially the usb i2c interface used a vid/pid pair donated by */
+/* Future Technology Devices International Ltd., later a pair was */
+/* bought from EZPrototypes */
 static struct usb_device_id i2c_tiny_usb_table [] = {
-	{ USB_DEVICE(0x0403, 0xc631) },
-	{ }			/* Terminating entry */
+	{ USB_DEVICE(0x0403, 0xc631) },   /* FTDI */
+	{ USB_DEVICE(0x1c40, 0x0534) },   /* EZPrototypes */
+	{ } /* Terminating entry */
 };
 
 MODULE_DEVICE_TABLE(usb, i2c_tiny_usb_table);

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

Re: [PATCH] New VID/PID pair for i2c-tiny-usb

[Jean Delvare]

Hi Till,

On Mon, 24 Mar 2008 10:42:30 +0100, Till Harbaum / Lists wrote:
> I have recently bought some USB PIDs from EZPrototypes for my USB projects
> and one will be for the i2c-tiny-usb. I have not yet started to use the new 
> one in the official i2c-tiny-usb firmware since i think it makes sense to get 
> the change into the kernel before releasing a modified firmware.
> 
> This patch adds support for the EZPrototypes USB vid/pid pair used in later
> i2c-tiny-usb firmware versions (avrusb v1.06 and up, usbtiny v2.06 and up).
> 
> Signed-off-by: Till Harbaum <Till-zicpKgigMvpAfugRpC6u6w@public.gmane.org>
> 
> --- linux-2.6.24.3.orig/drivers/i2c/busses/i2c-tiny-usb.c	2008-02-26 
> 01:20:20.000000000 +0100
> +++ linux-2.6.24.3/drivers/i2c/busses/i2c-tiny-usb.c	2008-03-24 
> 10:27:13.000000000 +0100

Note: your e-mail client is wrapping long lines -> patch doesn't apply.

> @@ -131,11 +131,13 @@
>  
>  /* ----- begin of usb layer ---------------------------------------------- */
>  
> -/* The usb i2c interface uses a vid/pid pair donated by */
> -/* Future Technology Devices International Ltd. */
> +/* Initially the usb i2c interface used a vid/pid pair donated by */
> +/* Future Technology Devices International Ltd., later a pair was */
> +/* bought from EZPrototypes */

Please use a single /* */ pair for multi-line comments.

>  static struct usb_device_id i2c_tiny_usb_table [] = {
> -	{ USB_DEVICE(0x0403, 0xc631) },
> -	{ }			/* Terminating entry */
> +	{ USB_DEVICE(0x0403, 0xc631) },   /* FTDI */
> +	{ USB_DEVICE(0x1c40, 0x0534) },   /* EZPrototypes */
> +	{ } /* Terminating entry */
>  };
>  
>  MODULE_DEVICE_TABLE(usb, i2c_tiny_usb_table);

Maybe I'm missing something obvious, but if you already have a device
ID, what's the point of switching to another? The original ID is not
going to be deprecated and/or used for something else, is it?

-- 
Jean Delvare

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

Re: [PATCH] New VID/PID pair for i2c-tiny-usb

[Till Harbaum / Lists]

Hi,

Am Mittwoch 26 März 2008 schrieb Jean Delvare:
> Note: your e-mail client is wrapping long lines -> patch doesn't apply.
I thought i've verified that, but obviously it happened anyway.

> Please use a single /* */ pair for multi-line comments.
Ok

> Maybe I'm missing something obvious, but if you already have a device
> ID, what's the point of switching to another? The original ID is not
> going to be deprecated and/or used for something else, is it?
The original id was donated by ftdi without stating anywhere that the id has 
to be used with their products. So i used it for the i2c-tiny-usb which 
obviously isn't based on a ftdi chipset. I've been told that ftdi has changed 
that policy lately. While i don't expect them to actually ask me not to use 
their id without using the chips i thought it was clever to switch to an id 
i've explicitely bought to avoid future problems with ftdis new policies. 
I'll change the id from the ftdi ones to the ones i recently bought on all my 
projects. Just to avoid future problems as early as possible.

Does this make sense?

Updated patch will follow.

Regards,
  Till

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

Re: [PATCH] New VID/PID pair for i2c-tiny-usb

[Jean Delvare]

Hi Till,

On Thu, 27 Mar 2008 20:47:21 +0100, Till Harbaum / Lists wrote:
> Am Mittwoch 26 März 2008 schrieb Jean Delvare:
> > Note: your e-mail client is wrapping long lines -> patch doesn't apply.
> I thought i've verified that, but obviously it happened anyway.
> 
> > Please use a single /* */ pair for multi-line comments.
> Ok
> 
> > Maybe I'm missing something obvious, but if you already have a device
> > ID, what's the point of switching to another? The original ID is not
> > going to be deprecated and/or used for something else, is it?
> The original id was donated by ftdi without stating anywhere that the id has 
> to be used with their products. So i used it for the i2c-tiny-usb which 
> obviously isn't based on a ftdi chipset. I've been told that ftdi has changed 
> that policy lately. While i don't expect them to actually ask me not to use 
> their id without using the chips i thought it was clever to switch to an id 
> i've explicitely bought to avoid future problems with ftdis new policies. 
> I'll change the id from the ftdi ones to the ones i recently bought on all my 
> projects. Just to avoid future problems as early as possible.
> 
> Does this make sense?

Yes it does, thanks for clarifying. Please send an updated patch and
I'll apply it.

> Updated patch will follow.

Do you plan to phase out the old VID/PID pair? If so, I'll have to send
you back my i2c-tiny-usb device for a firmware update.

-- 
Jean Delvare

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

Re: [PATCH] New VID/PID pair for i2c-tiny-usb

[Till Harbaum / Lists]

[-- Attachment #1: Type: text/plain, Size: 971 bytes --]

Hi,

Am Sonntag 30 März 2008 schrieb Jean Delvare:
> > Does this make sense?
>
> Yes it does, thanks for clarifying. Please send an updated patch and
> I'll apply it.
Please find a new patch attached.

> Do you plan to phase out the old VID/PID pair? If so, I'll have to send
> you back my i2c-tiny-usb device for a firmware update.
Nothing will change for people using the old vid/pid pair as the driver still 
supports that and i don't think there's a reason to also remove
the old vid/pid pair from the driver. But since you don't have the latest 
firmware, you might of course return your device anyway to get it updated. 
It'll then be detected correctly if it's plugged in at boot time.

Till

So here we go:

This patch adds support for the EZPrototypes USB vid/pid pair used in later
i2c-tiny-usb firmware versions (avrusb v1.06 and up, usbtiny v2.06 and up).

Signed-off-by: Till Harbaum <Till-zicpKgigMvpAfugRpC6u6w@public.gmane.org>


[-- Attachment #2: i2c-tiny-usb-ezprototypes.patch --]
[-- Type: text/x-diff, Size: 910 bytes --]

--- linux-2.6.24.3.orig/drivers/i2c/busses/i2c-tiny-usb.c	2008-02-26 01:20:20.000000000 +0100
+++ linux-2.6.24.3/drivers/i2c/busses/i2c-tiny-usb.c	2008-03-30 20:47:46.000000000 +0200
@@ -131,11 +131,15 @@
 
 /* ----- begin of usb layer ---------------------------------------------- */
 
-/* The usb i2c interface uses a vid/pid pair donated by */
-/* Future Technology Devices International Ltd. */
+/* 
+ * Initially the usb i2c interface uses a vid/pid pair donated by
+ * Future Technology Devices International Ltd., later a pair was
+ * bought from EZPrototypes 
+ */
 static struct usb_device_id i2c_tiny_usb_table [] = {
-	{ USB_DEVICE(0x0403, 0xc631) },
-	{ }			/* Terminating entry */
+	{ USB_DEVICE(0x0403, 0xc631) },   /* FTDI */
+	{ USB_DEVICE(0x1c40, 0x0534) },   /* EZPrototypes */
+	{ }                               /* Terminating entry */
 };
 
 MODULE_DEVICE_TABLE(usb, i2c_tiny_usb_table);

[-- Attachment #3: Type: text/plain, Size: 157 bytes --]

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

Re: [PATCH] New VID/PID pair for i2c-tiny-usb

[Jean Delvare]

On Sun, 30 Mar 2008 19:55:15 +0100, Till Harbaum / Lists wrote:
> Please find a new patch attached.

Applied, thanks.

-- 
Jean Delvare

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c