From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH 1/6] Blackfin I2C/TWI driver: Add repeat start feature to avoid break of a bundle of i2c master xfer operation. Date: Mon, 24 Mar 2008 19:20:45 +0100 Message-ID: <20080324192045.2343293c@hyperion.delvare> References: <1205479360-25240-2-git-send-email-cooloney@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1205479360-25240-2-git-send-email-cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org Errors-To: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org To: Bryan Wu Cc: Sonic Zhang , i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org List-Id: linux-i2c@vger.kernel.org Hi Bryan, On Fri, 14 Mar 2008 00:22:35 -0700, Bryan Wu wrote: > From: Sonic Zhang > > - Create a new mode TWI_I2C_MODE_REPEAT. > - No change to smbus operation. > > Signed-off-by: Sonic Zhang > Signed-off-by: Bryan Wu > Signed-off-by: Bryan Wu Just one Signed-off-by per person, please. > --- > drivers/i2c/busses/i2c-bfin-twi.c | 183 +++++++++++++++++++++++-------------- > 1 files changed, 113 insertions(+), 70 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-bfin-twi.c b/drivers/i2c/busses/i2c-bfin-twi.c > index 7dbdaeb..ea15125 100644 > --- a/drivers/i2c/busses/i2c-bfin-twi.c > +++ b/drivers/i2c/busses/i2c-bfin-twi.c > (...) It seems that this patch is the exact same as the one you posted back in November 2007: http://lists.lm-sensors.org/pipermail/i2c/2007-November/002119.html I did review this patch: http://lists.lm-sensors.org/pipermail/i2c/2007-November/002121.html So I would appreciate if you could take my comments into account and post an updated version. Thanks, -- Jean Delvare _______________________________________________ i2c mailing list i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org http://lists.lm-sensors.org/mailman/listinfo/i2c