From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Bryan Wu <cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org,
Michael Hennerich
<michael.hennerich-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 6/6] Blackfin I2C TWI driver: ADSP-BF52x arch/mach support
Date: Mon, 24 Mar 2008 22:33:10 +0100 [thread overview]
Message-ID: <20080324223310.7e3df49b@hyperion.delvare> (raw)
In-Reply-To: <1205479360-25240-7-git-send-email-cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On Fri, 14 Mar 2008 00:22:40 -0700, Bryan Wu wrote:
> From: Michael Hennerich <michael.hennerich-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
>
> Signed-off-by: Michael Hennerich <michael.hennerich-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Bryan Wu <bryan.wu-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Bryan Wu <cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
> drivers/i2c/busses/Kconfig | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 476b0bb..a1351ce 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -100,10 +100,10 @@ config I2C_AU1550
>
> config I2C_BLACKFIN_TWI
> tristate "Blackfin TWI I2C support"
> - depends on BF534 || BF536 || BF537 || BF54x
> + depends on BF534 || BF536 || BF537 || BF54x || BF522 || BF525 || BF527
> help
> - This is the TWI I2C device driver for Blackfin 534/536/537/54x.
> - This driver can also be built as a module. If so, the module
> + This is the TWI I2C device driver for Blackfin 522/525/527/534/536/537/54x.
> + This driver can also be built as a module. If so, the module
> will be called i2c-bfin-twi.
Now that the i2c-bfin-twi driver no longer requires special defines in
the arch/mach header files, wouldn't it be more simple to just make it
depend on BLACKFIN? Otherwise we'll have to update the "depends on"
statement over and over again with every new machine.
--
Jean Delvare
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
next prev parent reply other threads:[~2008-03-24 21:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 16:28 [PATCH 6/6] Blackfin I2C TWI driver: ADSP-BF52x arch/mach support Bryan Wu
[not found] ` <1205479360-25240-7-git-send-email-cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2008-03-24 21:33 ` Jean Delvare [this message]
[not found] ` <20080324223310.7e3df49b-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-03-25 3:55 ` Bryan Wu
[not found] ` <386072610803242055h648bc250sa27f7193044f18d5-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-03-25 14:17 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080324223310.7e3df49b@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=michael.hennerich-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox