public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] i2c: i2c-ibm_iic fast mode parm desc fixup.
@ 2008-03-25  6:35 Paul Mundt
       [not found] ` <20080325063529.GB29012-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Mundt @ 2008-03-25  6:35 UTC (permalink / raw)
  To: i2c-GZX6beZjE8VD60Wz+7aTrA, khali-PUYAD+kWke1g9hUCZPvPmw; +Cc: Andrew Morton

Noticed this when grepping for fast mode module params, the i2c-ibm_iic
driver was using a non-existent variable for MODULE_PARM_DESC. Fix it up
to reflect what it's actually supposed to be describing.

Signed-off-by: Paul Mundt <lethal-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>

---

 drivers/i2c/busses/i2c-ibm_iic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-ibm_iic.c b/drivers/i2c/busses/i2c-ibm_iic.c
index 7c7eb0c..22bb247 100644
--- a/drivers/i2c/busses/i2c-ibm_iic.c
+++ b/drivers/i2c/busses/i2c-ibm_iic.c
@@ -55,7 +55,7 @@ MODULE_PARM_DESC(iic_force_poll, "Force polling mode");
 
 static int iic_force_fast;
 module_param(iic_force_fast, bool, 0);
-MODULE_PARM_DESC(iic_fast_poll, "Force fast mode (400 kHz)");
+MODULE_PARM_DESC(iic_force_fast, "Force fast mode (400 kHz)");
 
 #define DBG_LEVEL 0
 

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] i2c: i2c-ibm_iic fast mode parm desc fixup.
       [not found] ` <20080325063529.GB29012-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
@ 2008-03-25 13:16   ` Jean Delvare
  0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2008-03-25 13:16 UTC (permalink / raw)
  To: Paul Mundt; +Cc: Andrew Morton, i2c-GZX6beZjE8VD60Wz+7aTrA

Hi Paul,

On Tue, 25 Mar 2008 15:35:29 +0900, Paul Mundt wrote:
> Noticed this when grepping for fast mode module params, the i2c-ibm_iic
> driver was using a non-existent variable for MODULE_PARM_DESC. Fix it up
> to reflect what it's actually supposed to be describing.
> 
> Signed-off-by: Paul Mundt <lethal-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
> 
> ---
> 
>  drivers/i2c/busses/i2c-ibm_iic.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-ibm_iic.c b/drivers/i2c/busses/i2c-ibm_iic.c
> index 7c7eb0c..22bb247 100644
> --- a/drivers/i2c/busses/i2c-ibm_iic.c
> +++ b/drivers/i2c/busses/i2c-ibm_iic.c
> @@ -55,7 +55,7 @@ MODULE_PARM_DESC(iic_force_poll, "Force polling mode");
>  
>  static int iic_force_fast;
>  module_param(iic_force_fast, bool, 0);
> -MODULE_PARM_DESC(iic_fast_poll, "Force fast mode (400 kHz)");
> +MODULE_PARM_DESC(iic_force_fast, "Force fast mode (400 kHz)");
>  
>  #define DBG_LEVEL 0
>  

Good catch. Patch applied, thank you. It seems that it has been broken
pretty much forever. I thought that building would fail in this case,
but it seems not.

-- 
Jean Delvare

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-03-25 13:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-25  6:35 [PATCH] i2c: i2c-ibm_iic fast mode parm desc fixup Paul Mundt
     [not found] ` <20080325063529.GB29012-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
2008-03-25 13:16   ` Jean Delvare

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox