From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Paul Mundt <lethal-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
Cc: Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCH] i2c: i2c-ibm_iic fast mode parm desc fixup.
Date: Tue, 25 Mar 2008 14:16:53 +0100 [thread overview]
Message-ID: <20080325141653.5ce67d6a@hyperion.delvare> (raw)
In-Reply-To: <20080325063529.GB29012-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
Hi Paul,
On Tue, 25 Mar 2008 15:35:29 +0900, Paul Mundt wrote:
> Noticed this when grepping for fast mode module params, the i2c-ibm_iic
> driver was using a non-existent variable for MODULE_PARM_DESC. Fix it up
> to reflect what it's actually supposed to be describing.
>
> Signed-off-by: Paul Mundt <lethal-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
>
> ---
>
> drivers/i2c/busses/i2c-ibm_iic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-ibm_iic.c b/drivers/i2c/busses/i2c-ibm_iic.c
> index 7c7eb0c..22bb247 100644
> --- a/drivers/i2c/busses/i2c-ibm_iic.c
> +++ b/drivers/i2c/busses/i2c-ibm_iic.c
> @@ -55,7 +55,7 @@ MODULE_PARM_DESC(iic_force_poll, "Force polling mode");
>
> static int iic_force_fast;
> module_param(iic_force_fast, bool, 0);
> -MODULE_PARM_DESC(iic_fast_poll, "Force fast mode (400 kHz)");
> +MODULE_PARM_DESC(iic_force_fast, "Force fast mode (400 kHz)");
>
> #define DBG_LEVEL 0
>
Good catch. Patch applied, thank you. It seems that it has been broken
pretty much forever. I thought that building would fail in this case,
but it seems not.
--
Jean Delvare
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
prev parent reply other threads:[~2008-03-25 13:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-25 6:35 [PATCH] i2c: i2c-ibm_iic fast mode parm desc fixup Paul Mundt
[not found] ` <20080325063529.GB29012-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
2008-03-25 13:16 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080325141653.5ce67d6a@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=lethal-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox