From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: "Zhang, Sonic" <Sonic.Zhang-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
Cc: i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCH 1/6] Blackfin I2C/TWI driver: Add repeat start feature to avoid break of a bundle of i2c master xfer operation.
Date: Tue, 25 Mar 2008 15:04:28 +0100 [thread overview]
Message-ID: <20080325150428.6031264f@hyperion.delvare> (raw)
In-Reply-To: <0F1B54C89D5F954D8535DB252AF412FA01B17710-SGdA1W8gREmuVPpjEGsWsTcYPEmu4y7e@public.gmane.org>
Hi Sonic,
On Tue, 25 Mar 2008 11:01:18 +0800, Zhang, Sonic wrote:
> I have already discussed your questions with you in attached email. See
> bellow. The twi controller is designed to support SMBus protocol in
> hardware. That's why we implement bfin_twi_smbus_xfer().
This is news to me, you did not tell this to me before. If there are
hardware optimizations for SMBus then indeed it makes sense to have
different code in the driver for I2C support and SMBus support.
Still, I had several objections to the patch that was submitted in
November 2007 (and resubmitted unchanged one week ago). I really would
like to see them addressed.
Thanks,
--
Jean Delvare
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
next prev parent reply other threads:[~2008-03-25 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 16:26 [PATCH 1/6] Blackfin I2C/TWI driver: Add repeat start feature to avoid break of a bundle of i2c master xfer operation Bryan Wu
[not found] ` <1205479360-25240-2-git-send-email-cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2008-03-24 18:20 ` Jean Delvare
[not found] ` <20080324192045.2343293c-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-03-25 3:01 ` Zhang, Sonic
[not found] ` <0F1B54C89D5F954D8535DB252AF412FA01B17710-SGdA1W8gREmuVPpjEGsWsTcYPEmu4y7e@public.gmane.org>
2008-03-25 14:04 ` Jean Delvare [this message]
[not found] ` <20080325150428.6031264f-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-03-26 7:59 ` Zhang, Sonic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080325150428.6031264f@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=Sonic.Zhang-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox