From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH] New VID/PID pair for i2c-tiny-usb Date: Wed, 26 Mar 2008 15:44:15 +0100 Message-ID: <20080326154415.2981961a@hyperion.delvare> References: <200803241042.31263.lists@harbaum.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200803241042.31263.lists-RcHadlBFbzVAfugRpC6u6w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org Errors-To: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org To: Till Harbaum / Lists Cc: i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org List-Id: linux-i2c@vger.kernel.org Hi Till, On Mon, 24 Mar 2008 10:42:30 +0100, Till Harbaum / Lists wrote: > I have recently bought some USB PIDs from EZPrototypes for my USB projects > and one will be for the i2c-tiny-usb. I have not yet started to use the new > one in the official i2c-tiny-usb firmware since i think it makes sense to get > the change into the kernel before releasing a modified firmware. > > This patch adds support for the EZPrototypes USB vid/pid pair used in later > i2c-tiny-usb firmware versions (avrusb v1.06 and up, usbtiny v2.06 and up). > > Signed-off-by: Till Harbaum > > --- linux-2.6.24.3.orig/drivers/i2c/busses/i2c-tiny-usb.c 2008-02-26 > 01:20:20.000000000 +0100 > +++ linux-2.6.24.3/drivers/i2c/busses/i2c-tiny-usb.c 2008-03-24 > 10:27:13.000000000 +0100 Note: your e-mail client is wrapping long lines -> patch doesn't apply. > @@ -131,11 +131,13 @@ > > /* ----- begin of usb layer ---------------------------------------------- */ > > -/* The usb i2c interface uses a vid/pid pair donated by */ > -/* Future Technology Devices International Ltd. */ > +/* Initially the usb i2c interface used a vid/pid pair donated by */ > +/* Future Technology Devices International Ltd., later a pair was */ > +/* bought from EZPrototypes */ Please use a single /* */ pair for multi-line comments. > static struct usb_device_id i2c_tiny_usb_table [] = { > - { USB_DEVICE(0x0403, 0xc631) }, > - { } /* Terminating entry */ > + { USB_DEVICE(0x0403, 0xc631) }, /* FTDI */ > + { USB_DEVICE(0x1c40, 0x0534) }, /* EZPrototypes */ > + { } /* Terminating entry */ > }; > > MODULE_DEVICE_TABLE(usb, i2c_tiny_usb_table); Maybe I'm missing something obvious, but if you already have a device ID, what's the point of switching to another? The original ID is not going to be deprecated and/or used for something else, is it? -- Jean Delvare _______________________________________________ i2c mailing list i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org http://lists.lm-sensors.org/mailman/listinfo/i2c