Re: [patch 2.6.25-rc8] i2c: fix platform driver hotplug/coldplug

From: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
Cc: Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>,
	Kay Sievers <kay.sievers-tD+1rO4QERM@public.gmane.org>,
	i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [patch 2.6.25-rc8] i2c: fix platform driver hotplug/coldplug
Date: Thu, 10 Apr 2008 10:30:09 -0700	[thread overview]
Message-ID: <20080410103009.0d3f39ec.akpm@linux-foundation.org> (raw)
In-Reply-To: <200804100949.10255.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>

On Thu, 10 Apr 2008 09:49:09 -0700 David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> wrote:

> On Thursday 10 April 2008, Jean Delvare wrote:
> > On Wed, 9 Apr 2008 13:54:07 -0700, David Brownell wrote:
> > > From: Kay Sievers <kay.sievers-tD+1rO4QERM@public.gmane.org>
> > > 
> > > Since 43cc71eed1250755986da4c0f9898f9a635cb3bf, the platform
> > > modalias is prefixed with "platform:". Add MODULE_ALIAS() to the
> > > hotpluggable I2C platform drivers, to allow module auto loading.
> > > 
> > > [ db: add some more drivers ]
> > > 
> > > Signed-off-by: Kay Sievers <kay.sievers-tD+1rO4QERM@public.gmane.org>
> > > Signed-off-by: David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
> > > ---
> > >  drivers/i2c/busses/...
> > >  17 files changed, 29 insertions(+), 1 deletion(-)
> > 
> > <snip>
> > 
> > OK... Is this a regression we need to fix in 2.6.25, or can this patch
> > wait until 2.6.26?
> 
> It was a regresssion as of 2.6.24, for 200+ drivers;
> every platform_bus driver used have hotplug/coldplug
> support, but that patch stopped that from working.
> 
> The thing is, that had only been working for a few
> releases at that time, so not many folk were relying
> on it yet.  They would just have been able to start
> doing so when that mechanism stopped working.
> 
> So I can't see a rush to get this into 2.6.25 now.
> I think the 200+ drivers will hotplug/coldplug again
> in 2.6.26 ... I've pushed almost a hundred such driver
> updates by now (sigh).
> 

Oh.  I was thinking we should slam all these fixes into 2.6.25.
If a couple fo them cause problems then we can patch things up in
2.6.25.x, but that's beter than having hundreds of broken drivers.

Or does your "as of" above mean that 2.6.24 is also busted?

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c