public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Juergen Beisert <jbe@pengutronix.de>
To: linux-arm-kernel@lists.arm.linux.org.uk
Cc: Darius <augulis.darius@gmail.com>, i2c@lm-sensors.org
Subject: Re: [PATCH V3] I2C driver for IMX
Date: Thu, 10 Apr 2008 13:33:51 +0200	[thread overview]
Message-ID: <200804101333.52241.jbe@pengutronix.de> (raw)
In-Reply-To: <ftkqk1$hsa$1@ger.gmane.org>

On Thursday 10 April 2008 12:33, Darius wrote:
> Jean Delvare wrote:
> > On Wed, 9 Apr 2008 22:25:39 -0500 (CDT), Kumar Gala wrote:
> >> On Thu, 10 Apr 2008, Ben Dooks wrote:
> >>> On Tue, Apr 08, 2008 at 11:01:25AM +0300, Darius wrote:
> >>>> changes:
> >>>> 1. Removed hardcoded constants
> >>>> 2. Fixed bug in chip hardware
> >>>> 3. Added i2c device for mx1ads
> >>>>
> >>>> Tested with mx1ads v2.0 board and LCD on I2C interface driver
> >>>>
> >>>> Signed-off-by: Darius Augulis <augulis.darius@gmail.com>
> >>>> ---
> >>>
> >>> Hmm, this hasn't appeared on the i2c list where it should be being
> >>> reviewed before submission. Not bothered to look or snip the rest.
> >>
> >> looking at this it seems the HW is identical to the driver handled by
> >> i2c-mpc.c.  (which is used on Motorola and now Freescale PPC chips).

Same answer as last year.

> > Then I guess that we want to add support to the i2c-mpc driver rather
> > than adding another driver to the kernel tree?
>
> I prefer to use separate driver for imx i2c inteface.
> if it's not needed for all, I'll leave it for my private needs.
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
As I did with my imx i2c driver last year....Yes, this I2C controller is 
mostly the same than the one in the MPC family and mostly the same the ones 
we can find in the MCX family (i.MX21/27, i.MX31?). But it seems there is 
noone who is able to write such a generic driver.

Juergen
-- 
Dipl.-Ing. Juergen Beisert | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
    Handelsregister: Amtsgericht Hildesheim, HRA 2686
         Vertretung Sued/Muenchen, Germany
   Phone: +49-8766-939 228 |  Fax: +49-5121-206917-9

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php

  reply	other threads:[~2008-04-10 11:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-08  8:01 [PATCH V3] I2C driver for IMX Darius
2008-04-09 23:28 ` Ben Dooks
     [not found]   ` <20080409232834.GG1197-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2008-04-10  3:25     ` Kumar Gala
2008-04-10 10:01       ` Jean Delvare
     [not found]         ` <20080410120141.4d220d27-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-04-10 10:09           ` Kumar Gala
2008-04-10 10:33         ` Darius
2008-04-10 11:33           ` Juergen Beisert [this message]
2008-04-10 12:24             ` Russell King - ARM Linux
2008-04-10 12:31               ` Darius
2008-04-14  0:55                 ` Pavel Pisa
2008-04-15 11:03 ` Darius

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804101333.52241.jbe@pengutronix.de \
    --to=jbe@pengutronix.de \
    --cc=augulis.darius@gmail.com \
    --cc=i2c@lm-sensors.org \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox