From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH] Add a new-style driver for most I2C EEPROMs Date: Fri, 18 Apr 2008 12:31:49 +0200 Message-ID: <20080418103149.GA4245@pengutronix.de> References: <1207914198-8561-1-git-send-email-w.sang@pengutronix.de> <20080414143925.31b55b39@hyperion.delvare> <200804140857.33732.david-b@pacbell.net> <200804171417.23753.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2842337698499894018==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org Errors-To: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org To: Trent Piepho Cc: David Brownell , i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org List-Id: linux-i2c@vger.kernel.org --===============2842337698499894018== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wac7ysb48OaltWcw" Content-Disposition: inline --wac7ysb48OaltWcw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 18, 2008 at 01:07:51AM -0700, Trent Piepho wrote: > So the loop tries the write for the first time, fails (which is perfectly > acceptable), then sleeps for more than timeout jiffies. The timeout > expires and the write is never tried again. Ehrm, the conditions for the while loop are OR-ed not AND-ed. So, even if time_before changes to false, 'retries < 3' will keep the loop running. I think this minimum of three tries will also cover the other issues you (correctly) mentioned. Wolfram --=20 Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry --wac7ysb48OaltWcw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFICHiVD27XaX1/VRsRAvUwAJ9AVCD25kBVJDeGrRypie5XWCHI+QCfWupc 76gGE2ArwKBT/OvpUIjKmpQ= =Wmrb -----END PGP SIGNATURE----- --wac7ysb48OaltWcw-- --===============2842337698499894018== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ i2c mailing list i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org http://lists.lm-sensors.org/mailman/listinfo/i2c --===============2842337698499894018==--