public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Paul Mundt <lethal@linux-sh.org>
Cc: khali@linux-fr.org, mano@roarinelk.homelinux.net,
	i2c@lm-sensors.org, linux-sh@vger.kernel.org, damm@igel.co.jp
Subject: Re: [PATCH] i2c: Renesas Highlander FPGA SMBus support.
Date: Thu, 24 Apr 2008 23:12:07 -0700	[thread overview]
Message-ID: <20080424231207.11a03f3d.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080425013011.GA27359@linux-sh.org>

> On Fri, 25 Apr 2008 10:30:11 +0900 Paul Mundt <lethal@linux-sh.org> wrote:
> On Wed, Apr 23, 2008 at 08:31:04PM +0200, Jean Delvare wrote:
> > On Wed, 23 Apr 2008 20:11:01 +0200, Manuel Lauss wrote:
> > > On Wed, Apr 23, 2008 at 01:41:56PM +0200, Jean Delvare wrote:
> > > > On Tue, 25 Mar 2008 15:32:36 +0900, Paul Mundt wrote:
> > > > > This adds support for the SMBus adapter found in the various FPGAs on
> > > > > the Renesas Highlander platforms. Particularly the R0P7780LC0011RL and
> > > > > R0P7785LC0011RL FPGAs.
> > > > > 
> > > > > Functionality is fairly restricted, in that only byte and block data
> > > > > transfers are supported. Normal/fast mode and IRQ/polling are also
> > > > > supported. Primarily used for various RTCs and thermal sensors.
> > > > > 
> > > > > Signed-off-by: Paul Mundt <lethal@linux-sh.org>
> > > > 
> > > > No volunteer to review this driver? Manuel or Magnus maybe?
> > > 
> > > I don't think I'm qualified to review other peoples' code (it looks
> > > fine to me).

I looked through it when I merged it - believe it or not, I always do
(well, except for some dopey mechanical code transformation patches where
I'll just believe the changelog).  I saw nothing worth commenting on.  As
is always the case when I don't comment ;)

So here's a
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>

Although that is of course of limited use, coming from a person
who isn't terribly sure what an i2c is.

  reply	other threads:[~2008-04-25  6:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-25  6:32 [PATCH] i2c: Renesas Highlander FPGA SMBus support Paul Mundt
2008-04-23 11:41 ` Jean Delvare
2008-04-23 18:11   ` Manuel Lauss
2008-04-23 18:31     ` Jean Delvare
2008-04-25  1:30       ` Paul Mundt
2008-04-25  6:12         ` Andrew Morton [this message]
2008-04-25  6:22           ` Paul Mundt
2008-04-25 10:03             ` Jean Delvare
2008-04-25  9:38 ` Jean Delvare
     [not found]   ` <20080425113835.5c212918-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-04-26  7:26     ` Trent Piepho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080424231207.11a03f3d.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=damm@igel.co.jp \
    --cc=i2c@lm-sensors.org \
    --cc=khali@linux-fr.org \
    --cc=lethal@linux-sh.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=mano@roarinelk.homelinux.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox