Re: [PATCH] i2c: Renesas Highlander FPGA SMBus support.

[Paul Mundt <lethal@linux-sh.org>]

On Wed, Apr 23, 2008 at 08:31:04PM +0200, Jean Delvare wrote:
> On Wed, 23 Apr 2008 20:11:01 +0200, Manuel Lauss wrote:
> > On Wed, Apr 23, 2008 at 01:41:56PM +0200, Jean Delvare wrote:
> > > On Tue, 25 Mar 2008 15:32:36 +0900, Paul Mundt wrote:
> > > > This adds support for the SMBus adapter found in the various FPGAs on
> > > > the Renesas Highlander platforms. Particularly the R0P7780LC0011RL and
> > > > R0P7785LC0011RL FPGAs.
> > > > 
> > > > Functionality is fairly restricted, in that only byte and block data
> > > > transfers are supported. Normal/fast mode and IRQ/polling are also
> > > > supported. Primarily used for various RTCs and thermal sensors.
> > > > 
> > > > Signed-off-by: Paul Mundt <lethal@linux-sh.org>
> > > 
> > > No volunteer to review this driver? Manuel or Magnus maybe?
> > 
> > I don't think I'm qualified to review other peoples' code (it looks
> > fine to me).  The other thing is Renesas demoboards are impossible to
> > get outside of Japan so I think Paul is the only user of this hardware
> > who is also interested in linux support. And I'm convinced he knows
> > what he's doing ;-)
> 
> I guess that there are more users than just Paul, otherwise he wouldn't
> bother pushing his driver upstream, would he?
> 
Even if I were the only user, I would still push it upstream. Though in
this case, there are plenty of other users. This is a fairly common
reference board in Japan, which we've supported in the kernel in various
forms for a few years already. The FPGA SMBus implementation is one of
the outstanding bits of support for the platform.