From: Rusty Russell <rusty@rustcorp.com.au>
To: Jean Delvare <khali@linux-fr.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Sam Ravnborg <sam@ravnborg.org>,
Kay Sievers <kay.sievers@vrfy.org>,
Linux I2C <i2c@lm-sensors.org>
Subject: Re: [PATCH] modpost: i2c aliases need no trailing wildcard
Date: Mon, 5 May 2008 10:09:05 +1000 [thread overview]
Message-ID: <200805051009.06159.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20080502203721.70c5dc09@hyperion.delvare>
On Saturday 03 May 2008 04:37:21 Jean Delvare wrote:
> Hi all,
>
> [Once more with Sam's address fixed, sorry for the noise.]
>
> Not all device types need a wildcard at the end of their module
> aliases. In particular, for i2c module aliases, the trailing wildcard
> is not only unneeded, it could also cause the wrong driver to be
> loaded.
Hi Jean,
i2c would have been better using a terminator char after the device name.
The wildcard would then allow future extensions without having the current
potential confusion.
Still, there's nothing wrong with this patch, happy for you to send it.
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Cheers,
Rusty.
next prev parent reply other threads:[~2008-05-05 0:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 18:37 [PATCH] modpost: i2c aliases need no trailing wildcard Jean Delvare
2008-05-03 12:21 ` [i2c] " Jochen Friedrich
2008-05-03 12:50 ` Jean Delvare
2008-05-03 18:04 ` Sam Ravnborg
2008-05-03 19:12 ` Jean Delvare
2008-05-05 0:09 ` Rusty Russell [this message]
2008-05-05 8:48 ` Jean Delvare
2008-05-05 9:09 ` Sam Ravnborg
2008-05-05 10:30 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805051009.06159.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=i2c@lm-sensors.org \
--cc=kay.sievers@vrfy.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox