From: Jean Delvare <khali@linux-fr.org>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Ralf Baechle <ralf@linux-mips.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
rtc-linux@googlegroups.com, i2c@lm-sensors.org,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 2/4] RTC: SWARM I2C board initialization
Date: Wed, 7 May 2008 09:05:14 +0200 [thread overview]
Message-ID: <20080507090514.3a86cf4b@hyperion.delvare> (raw)
In-Reply-To: <Pine.LNX.4.55.0805070031410.16173@cliff.in.clinika.pl>
Oh, BTW...
On Wed, 7 May 2008 01:40:27 +0100 (BST), Maciej W. Rozycki wrote:
> (...)
> 1. i2c-swarm.c -- SWARM I2C board setup, currently for the M41T80 chip on
> the bus #1 only.
> (...)
> --- linux-2.6.26-rc1-20080505.macro/arch/mips/sibyte/swarm/Makefile 2004-01-29 04:57:05.000000000 +0000
> +++ linux-2.6.26-rc1-20080505/arch/mips/sibyte/swarm/Makefile 2008-05-06 01:18:21.000000000 +0000
> @@ -1,3 +1,4 @@
> -lib-y = setup.o rtc_xicor1241.o rtc_m41t81.o
> +obj-y := setup.o rtc_xicor1241.o rtc_m41t81.o
>
> -lib-$(CONFIG_KGDB) += dbg_io.o
> +obj-$(CONFIG_I2C_BOARDINFO) += i2c-swarm.o
> +obj-$(CONFIG_KGDB) += dbg_io.o
> (...)
> --- linux-2.6.26-rc1-20080505.macro/arch/mips/sibyte/swarm/i2c-swarm.c 1970-01-01 00:00:00.000000000 +0000
> +++ linux-2.6.26-rc1-20080505/arch/mips/sibyte/swarm/i2c-swarm.c 2008-05-06 23:51:34.000000000 +0000
i2c-foo.c is consistently used for i2c bus driver themselves so far.
It's somewhat confusing to see you name platform code that way. It's
also redundant, given that the file lives in the swarm platform
directory. May I suggest naming this file just
arch/mips/sibyte/swarm/i2c.c? Other architectures (cris, arm) are doing
this already.
--
Jean Delvare
next prev parent reply other threads:[~2008-05-07 7:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 0:40 [RFC][PATCH 2/4] RTC: SWARM I2C board initialization Maciej W. Rozycki
2008-05-07 6:59 ` Jean Delvare
2008-05-07 7:08 ` Andrew Morton
2008-05-07 21:13 ` Maciej W. Rozycki
2008-05-08 4:51 ` Ralf Baechle
2008-05-08 22:43 ` Maciej W. Rozycki
2008-05-08 8:59 ` Jean Delvare
2008-05-08 23:10 ` Maciej W. Rozycki
2008-05-09 7:28 ` Jean Delvare
2008-05-09 20:27 ` Maciej W. Rozycki
2008-05-09 20:38 ` Jean Delvare
2008-05-10 1:43 ` Maciej W. Rozycki
2008-05-07 7:05 ` Jean Delvare [this message]
2008-05-07 7:37 ` Geert Uytterhoeven
2008-05-07 7:43 ` Jean Delvare
2008-05-07 21:25 ` Maciej W. Rozycki
2008-05-08 4:57 ` Ralf Baechle
2008-05-08 7:56 ` Jean Delvare
2008-05-09 19:36 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080507090514.3a86cf4b@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=i2c@lm-sensors.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=rtc-linux@googlegroups.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox