From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [RFC][PATCH 2/4] RTC: SWARM I2C board initialization Date: Fri, 9 May 2008 22:38:45 +0200 Message-ID: <20080509223845.4a38d751@hyperion.delvare> References: <20080507085953.2c08b854@hyperion.delvare> <20080508105905.3209c659@hyperion.delvare> <20080509092835.3bbf0f55@hyperion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org To: "Maciej W. Rozycki" Cc: Ralf Baechle , Alessandro Zummo , Thomas Gleixner , Andrew Morton , rtc-linux@googlegroups.com, i2c@lm-sensors.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, David Brownell List-Id: linux-i2c@vger.kernel.org Hi Maciej, On Fri, 9 May 2008 21:27:04 +0100 (BST), Maciej W. Rozycki wrote: > Well, sorry, but I could only sense the lack of style in this piece of > code, which is why I tried to apply some. I agree, i2c-sibyte is very old code, and unmaintained, coding style is horrible. That's one more reason to not include random style cleanups in a patch doing functional changes, the improvement will hardly be visible. If you care about cleaning up the code of this driver - and I would appreciate that - please make a separate patch. > You are free to disagree and as > you have undertaken maintenance of this area I am going to respect it. And I thank you for that. -- Jean Delvare