Re: [RFC][PATCH 4/4] RTC: SMBus support for the M41T80,

David Brownell
2008-05-09T08:39:13Z

On Thursday 08 May 2008, Jean Delvare wrote:
> > >  I think a pair of functions called i2c_smbus_read_i2c_byte_data() and
> > > i2c_smbus_write_i2c_byte_data() could be added to the core though.
> >
> > Too late.  Those calls have been in the I2C core for a long
> > time now.  ;)
>
> No, we don't have any function named that way. Not that I think that
> these names would be appropriate, though. I'd rather have
> i2c_smbus_read_i2c_block_emul() for example.

I didn't pick up on the context switch Maciej stuck in, as a
not-quite-response to my comment about the functions that the
m41t80 driver could *portably* use: the ones that have been
in the I2C core for some time now. I thought he missed the
point that those operations were already present...

It's not at all clear what a "read i2c byte data" function
might do, for that matter. I2C doesn't define semantics
even to the weak level SMBus does.

If I had noticed that some previously un-discussed primitive
had been introduced, I would have asked for a definition in
terms of protocol, and expected semantics; I can't guess.

- Dave

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org