* [PATCH] I2C: SiByte: Mark i2c_sibyte_add_bus() as static
@ 2008-05-11 2:14 Maciej W. Rozycki
2008-05-11 9:07 ` Jean Delvare
0 siblings, 1 reply; 2+ messages in thread
From: Maciej W. Rozycki @ 2008-05-11 2:14 UTC (permalink / raw)
To: Jean Delvare, Andrew Morton
Cc: i2c-GZX6beZjE8VD60Wz+7aTrA, linux-kernel-u79uwXL29TY76Z2rM5mHXA
The i2c_sibyte_add_bus() function is not called, nor meant to, from
outside, so mark it as static; fixing a sparse warning too.
Signed-off-by: Maciej W. Rozycki <macro-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
---
It should be obvious. Please apply.
Maciej
patch-2.6.26-rc1-20080505-sibyte-i2c-sparse-16
diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/drivers/i2c/busses/i2c-sibyte.c linux-2.6.26-rc1-20080505/drivers/i2c/busses/i2c-sibyte.c
--- linux-2.6.26-rc1-20080505.macro/drivers/i2c/busses/i2c-sibyte.c 2008-05-05 02:55:25.000000000 +0000
+++ linux-2.6.26-rc1-20080505/drivers/i2c/busses/i2c-sibyte.c 2008-05-11 01:11:00.000000000 +0000
@@ -132,7 +132,7 @@ static const struct i2c_algorithm i2c_si
/*
* registering functions to load algorithms at runtime
*/
-int __init i2c_sibyte_add_bus(struct i2c_adapter *i2c_adap, int speed)
+static int __init i2c_sibyte_add_bus(struct i2c_adapter *i2c_adap, int speed)
{
struct i2c_algo_sibyte_data *adap = i2c_adap->algo_data;
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] I2C: SiByte: Mark i2c_sibyte_add_bus() as static
2008-05-11 2:14 [PATCH] I2C: SiByte: Mark i2c_sibyte_add_bus() as static Maciej W. Rozycki
@ 2008-05-11 9:07 ` Jean Delvare
0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2008-05-11 9:07 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: Andrew Morton, i2c, linux-kernel
On Sun, 11 May 2008 03:14:05 +0100 (BST), Maciej W. Rozycki wrote:
> The i2c_sibyte_add_bus() function is not called, nor meant to, from
> outside, so mark it as static; fixing a sparse warning too.
>
> Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
> ---
> It should be obvious. Please apply.
>
> Maciej
>
> patch-2.6.26-rc1-20080505-sibyte-i2c-sparse-16
> diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/drivers/i2c/busses/i2c-sibyte.c linux-2.6.26-rc1-20080505/drivers/i2c/busses/i2c-sibyte.c
> --- linux-2.6.26-rc1-20080505.macro/drivers/i2c/busses/i2c-sibyte.c 2008-05-05 02:55:25.000000000 +0000
> +++ linux-2.6.26-rc1-20080505/drivers/i2c/busses/i2c-sibyte.c 2008-05-11 01:11:00.000000000 +0000
> @@ -132,7 +132,7 @@ static const struct i2c_algorithm i2c_si
> /*
> * registering functions to load algorithms at runtime
> */
> -int __init i2c_sibyte_add_bus(struct i2c_adapter *i2c_adap, int speed)
> +static int __init i2c_sibyte_add_bus(struct i2c_adapter *i2c_adap, int speed)
> {
> struct i2c_algo_sibyte_data *adap = i2c_adap->algo_data;
>
Applied, thanks.
--
Jean Delvare
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-11 9:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-11 2:14 [PATCH] I2C: SiByte: Mark i2c_sibyte_add_bus() as static Maciej W. Rozycki
2008-05-11 9:07 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox