From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH] i2c: Improve the functionality documentation Date: Sun, 11 May 2008 11:14:52 +0200 Message-ID: <20080511111452.6e76e939@hyperion.delvare> References: <20080510103937.1c74ca8c@hyperion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org Errors-To: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org To: "Maciej W. Rozycki" Cc: David Brownell , Linux I2C List-Id: linux-i2c@vger.kernel.org On Sun, 11 May 2008 08:23:01 +0100 (BST), Maciej W. Rozycki wrote: > On Sat, 10 May 2008, Jean Delvare wrote: > > > Attempt to make the documentation about the I2C/SMBus functionality > > checking API clearer. > > It looks good to me. A minor nit below. Thanks for the review. > > > + if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA | > > + I2C_FUNC_SMBUS_WORD_DATA)) > > Indentation (obviously it is the driver you are referring to that has got > it wrong in the first place). There's nothing wrong with indentation here. Alignment on opening parenthesis is a common strategy, and checkpatch.pl accepts it. -- Jean Delvare _______________________________________________ i2c mailing list i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org http://lists.lm-sensors.org/mailman/listinfo/i2c