From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Alek Du <alek.du-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCH] i2c: Add Intel SCH I2C SMBus support
Date: Mon, 12 May 2008 21:40:04 +0200 [thread overview]
Message-ID: <20080512214004.6db3375d@hyperion.delvare> (raw)
In-Reply-To: <48124673.8020808-/xGekIyIa4Ap1Coe8Ar9gA@public.gmane.org>
On Fri, 25 Apr 2008 23:00:35 +0200, Rudolf Marek wrote:
> > +/* SCH SMBus address offsets */
> > +#define SMBHSTCNT (0 + sch_smba)
> > +#define SMBHSTSTS (1 + sch_smba)
> > +#define SMBHSTADD (4 + sch_smba) /* TSA */
> > +#define SMBHSTCMD (5 + sch_smba)
> > +#define SMBHSTDAT0 (6 + sch_smba)
> > +#define SMBHSTDAT1 (7 + sch_smba)
> > +#define SMBBLKDAT (0x20 + sch_smba)
> > +
> > +
> > +/* count for request_region */
> > +#define SMBIOSIZE 8
>
> No it is 64 bytes
The datasheet has contradictions. It says 32 bytes in section 5.4.2,
table 13. But it says 64 bytes in section 17.3.1. Given that the block
registers span from offset 32 to offset 63, the latter is obviously
correct.
Alek, can you please have table 13 fixed in the datasheet?
--
Jean Delvare
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
prev parent reply other threads:[~2008-05-12 19:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 2:05 [PATCH] i2c: Add Intel SCH I2C SMBus support Alek Du
[not found] ` <20080424100510.09cc2d4b-PCb9FJy6fea75v1z/vFq2g@public.gmane.org>
2008-04-25 11:49 ` Rudolf Marek
2008-04-25 21:00 ` Rudolf Marek
[not found] ` <48124673.8020808-/xGekIyIa4Ap1Coe8Ar9gA@public.gmane.org>
2008-04-26 7:50 ` Jean Delvare
[not found] ` <20080426095011.2d27b75b-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-04-27 13:56 ` Alek Du
2008-04-28 6:45 ` Alek Du
[not found] ` <20080428144514.53aa54fd-PCb9FJy6fea75v1z/vFq2g@public.gmane.org>
2008-04-28 8:57 ` Jean Delvare
[not found] ` <20080428105738.06429ed2-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-04-29 3:06 ` [PATCH] i2c: Add Intel SCH I2C SMBus support (revised) Alek Du
[not found] ` <8AD95083DC3E36478732061D97524415030F8FAA@pdsmsx411.ccr.corp.intel.com>
[not found] ` <20080430080351.57b8c21d@hyperion.delvare>
[not found] ` <20080505141807.1aa458e1@dxy.sh.intel.com>
[not found] ` <20080505110757.6454c220@hyperion.delvare>
[not found] ` <20080506095036.274e91f1@dxy.sh.intel.com>
[not found] ` <20080506095036.274e91f1-PCb9FJy6fea75v1z/vFq2g@public.gmane.org>
2008-05-12 20:57 ` Jean Delvare
[not found] ` <20080512225718.7440ab42-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-05-20 5:56 ` [PATCH v3] i2c: Add Intel SCH I2C SMBus support Alek Du
[not found] ` <20080520135635.55238a08-PCb9FJy6fea75v1z/vFq2g@public.gmane.org>
2008-05-20 9:31 ` Jean Delvare
[not found] ` <20080520113140.44e40b77-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-05-21 2:21 ` [PATCH v4] " Alek Du
[not found] ` <20080521102105.13d75e59-PCb9FJy6fea75v1z/vFq2g@public.gmane.org>
2008-05-21 9:04 ` Jean Delvare
2008-05-20 11:10 ` [PATCH v3] " Jean Delvare
2008-05-12 19:40 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080512214004.6db3375d@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=alek.du-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox