From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Darius <augulis.darius-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org,
linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org
Subject: Re: [PATCH V4] I2C bus driver for IMX
Date: Thu, 15 May 2008 10:30:04 +0200 [thread overview]
Message-ID: <20080515083004.GA4302@pengutronix.de> (raw)
In-Reply-To: <g0gqiq$21q$1@ger.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 1154 bytes --]
On Thu, May 15, 2008 at 10:55:30AM +0300, Darius wrote:
> >> + for (i=0; i<I2C_IMX_TIME_BUSY; i++) {
> > spacing in here: for (i = 0; i < I2C_IMX_TIME_BUSY; i++)
> what is there wrong with spacing?
>
> > spacing in here, (temp & I2CR_IEN) ? 1 : 0
> I really should add dummy spaces...?
Please do. Documentation/CodingStyle recommends it. While personal
opinions on ceratin topics may vary, I think it is indeed helpful,
if all kernel sources look somewhat similar.
> > yeurk, put these in a seperate header file, or place them near
> > the driver. The "One Big Register File" is horrible, and hopefully
> seems, everybody has her own opinion. Is there somebody one, who can say
> how that should be? Because I have already two times changed that... I'm
> only beginner, so ambiguous comments are very unwanted... As I know,
> Jean Delvare is responsible for I2C drivers. So, his word is welcome:)
He suggested the same (= no register file) to me in January for the
PCA9564-driver.
All the best,
Wolfram
--
Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de
Pengutronix - Linux Solutions for Science and Industry
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
next prev parent reply other threads:[~2008-05-15 8:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 13:07 [PATCH V4] I2C bus driver for IMX Darius
2008-05-14 21:32 ` Ben Dooks
[not found] ` <20080514213214.GB16881-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2008-05-15 7:55 ` Darius
2008-05-15 8:30 ` Wolfram Sang [this message]
2008-05-15 9:59 ` Jean Delvare
2008-05-15 12:44 ` [PATCH V5] " Darius
2008-05-16 18:31 ` Trent Piepho
[not found] ` <Pine.LNX.4.58.0805161003320.23876-13q4cmjDBaTP3RPoUHIrnuTW4wlIGRCZ@public.gmane.org>
2008-05-20 6:39 ` Darius
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080515083004.GA4302@pengutronix.de \
--to=w.sang-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=augulis.darius-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox