Re: [PATCH] i2c-pcf8575: check for errors when accessing the chip

Bart Van Assche
2008-05-16T06:10:46Z

On Thu, May 15, 2008 at 4:29 PM, Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
> Make the driver check and report error cases when reading from or writing to
> the chip. It used to assume 'always success' and could even deliver bogus
> values.
>
> Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

It's definitely an improvement that the return value of i2c_master_*()
is now checked -- I did not have any defective PCF8575 devices around
when I submitted the PCF8575 patch. Can you please add one or two
lines to Documentation/i2c/chips/pcf8575 that explain what happens to
the /sys variables in case of a read or write error ?

Thanks,

Bart.