[PATCH] i2c-pca-algo: Fix errorcode

[PATCH] i2c-pca-algo: Fix errorcode

[Wolfram Sang]

Give a more concrete error code, when the bus is not idle.

Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---

 drivers/i2c/algos/i2c-algo-pca.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/i2c/algos/i2c-algo-pca.c b/drivers/i2c/algos/i2c-algo-pca.c
index e954a20..8001d6d 100644
--- a/drivers/i2c/algos/i2c-algo-pca.c
+++ b/drivers/i2c/algos/i2c-algo-pca.c
@@ -182,7 +182,7 @@ static int pca_xfer(struct i2c_adapter *i2c_adap,
 	}
 	if (state != 0xf8) {
 		dev_dbg(&i2c_adap->dev, "bus is not idle. status is %#04x\n", state);
-		return -EIO;
+		return -EBUSY;
 	}
 
 	DEB1("{{{ XFER %d messages\n", num);


_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

Re: [PATCH] i2c-pca-algo: Fix errorcode

[Jean Delvare]

Hi Wolfram,

On Tue, 20 May 2008 19:18:49 +0200, Wolfram Sang wrote:
> Give a more concrete error code, when the bus is not idle.
> 
> Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> ---
> 
>  drivers/i2c/algos/i2c-algo-pca.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/i2c/algos/i2c-algo-pca.c b/drivers/i2c/algos/i2c-algo-pca.c
> index e954a20..8001d6d 100644
> --- a/drivers/i2c/algos/i2c-algo-pca.c
> +++ b/drivers/i2c/algos/i2c-algo-pca.c
> @@ -182,7 +182,7 @@ static int pca_xfer(struct i2c_adapter *i2c_adap,
>  	}
>  	if (state != 0xf8) {
>  		dev_dbg(&i2c_adap->dev, "bus is not idle. status is %#04x\n", state);
> -		return -EIO;
> +		return -EBUSY;
>  	}
>  
>  	DEB1("{{{ XFER %d messages\n", num);

EBUSY is a fatal error, while a you should be able to retry the
transaction later when the bus is free. So I think that EAGAIN would be
more appropriate.

-- 
Jean Delvare

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

Re: [PATCH] i2c-pca-algo: Fix errorcode

[Wolfram Sang]

[-- Attachment #1.1: Type: text/plain, Size: 748 bytes --]

Hi Jean,

On Tue, May 20, 2008 at 08:17:55PM +0200, Jean Delvare wrote:

> EBUSY is a fatal error, while a you should be able to retry the
> transaction later when the bus is free. So I think that EAGAIN would be
> more appropriate.
Okay, fine with me. (Does somebody know of a guide with references for
using errorcodes? EBUSY or EAGAIN? ENODEV or ENXIO? Preferred error
value if ioremap fails? It seems a bit messy. The patch that was
recently posted, defining possible situations for errorcodes within I2C
is really great. I wished I would have something like this for the
general kernel-routines.)

   Wolfram

-- 
  Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c