From: Jean Delvare <khali@linux-fr.org>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: gregkh@suse.de, i2c@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] i2c : use class_for_each_device
Date: Wed, 21 May 2008 08:00:39 +0200 [thread overview]
Message-ID: <20080521080039.49e6ea9f@hyperion.delvare> (raw)
In-Reply-To: <a8e1da0805201830q88665afnf00e5f96f832f90@mail.gmail.com>
On Wed, 21 May 2008 09:30:59 +0800, Dave Young wrote:
> On Wed, May 21, 2008 at 9:29 AM, Dave Young <hidave.darkstar@gmail.com> wrote:
> > On Wed, May 21, 2008 at 1:31 AM, Jean Delvare <khali@linux-fr.org> wrote:
> >> ... but calling another one? Can't be correct. Which raises a question:
> >> you didn't test your patch, did you? I'm also surprised how you managed
> >> to mess this up, given that all you had to do was to move already
> >> existing code around.
> >
> > Thanks for review, It's only boot-tested with i2c part as built-in by
> > me because I have the i2c device to test.
>
> should be "have no the i2c device to test" ;)
Too late for this time, but for next time, you can emulate an i2c
device using the i2c-stub driver, that's very convenient when you want
to test a change that affects i2c and don't have any physical device to
test it.
--
Jean Delvare
prev parent reply other threads:[~2008-05-21 6:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-09 7:20 [PATCH 1/3] i2c : use class_for_each_device Dave Young
2008-05-20 17:31 ` Jean Delvare
2008-05-21 1:29 ` Dave Young
2008-05-21 1:30 ` Dave Young
2008-05-21 6:00 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080521080039.49e6ea9f@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=gregkh@suse.de \
--cc=hidave.darkstar@gmail.com \
--cc=i2c@lm-sensors.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox