From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Krzysztof Helt <krzysztof.h1-5tc4TXWwyLM@public.gmane.org>
Cc: "Rafał Haładuda" <rh1985-5tc4TXWwyLM@public.gmane.org>,
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCH] unhide smbus on Compaq Deskpro EN
Date: Sat, 31 May 2008 17:13:43 +0200 [thread overview]
Message-ID: <20080531171343.49dd8ceb@hyperion.delvare> (raw)
In-Reply-To: <20080530232118.1b0078ff.krzysztof.h1-5tc4TXWwyLM@public.gmane.org>
Hi Krzysztof,
On Fri, 30 May 2008 23:21:18 +0200, Krzysztof Helt wrote:
> From: Krzysztof Helt <krzysztof.h1@wp.pl>
>
> This patch unhides the smbus on Compaq Deskpro EN
> SFF P667 with the Intel 815E chipset.
> The patch was tested on Fedora Core 9 with 2.6.25.4 kernel.
>
> Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
> Tested-by: Rafał Haładuda <rh1985@wp.pl>
>
> ---
>
> No side effects were observed. The ACPI controlled fan
> correctly with the patch applied. Tested with 667 and
> 1000 MHz CPUs.
> The patch allows using the THMC51 sensor chip on
> the motherboard.
> The patch was done against the kernel 2.6.26-rc2-mm1
I would like to see the ACPI DSDT of this machine. If ACPI is
controlling the fan then there are good chances that unhiding the SMBus
is the wrong thing to do, even if you did not notice any problem yet.
Thanks,
--
Jean Delvare
_______________________________________________
i2c mailing list
i2c@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
next prev parent reply other threads:[~2008-05-31 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 21:21 [PATCH] unhide smbus on Compaq Deskpro EN Krzysztof Helt
[not found] ` <20080530232118.1b0078ff.krzysztof.h1-5tc4TXWwyLM@public.gmane.org>
2008-05-31 15:13 ` Jean Delvare [this message]
2008-06-04 11:58 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080531171343.49dd8ceb@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=krzysztof.h1-5tc4TXWwyLM@public.gmane.org \
--cc=rh1985-5tc4TXWwyLM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox