From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Subject: Re: [PATCH 2/3] i2c: Let bus drivers add SPD to their class Date: Tue, 3 Jun 2008 13:19:56 -0700 Message-ID: <200806031319.56606.david-b@pacbell.net> References: <20080603130221.1f819e64@hyperion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20080603130221.1f819e64-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org Errors-To: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org To: Jean Delvare Cc: Linux I2C List-Id: linux-i2c@vger.kernel.org On Tuesday 03 June 2008, Jean Delvare wrote: > = > Note that I took a conservative approach here, adding I2C_CLASS_SPD to > all drivers that had I2C_CLASS_HWMON before. This is to make sure that > the eeprom driver doesn't stop probing buses where SPD EEPROMs live. > But the truth is that, for most of these, I simply have no idea whether > they can host SPD EEPROMs or not. Few embedded platforms use discrete sticks of DRAM. My two cents: use the opposite default in those cases. I'll highlight a few below, where I happen to have more specific knowledge. > So, bus driver maintainers and users = > should feel free to remove the SPD class from drivers those buses never > have SPD EEPROMs or they don't want the eeprom driver to bind to them. > Likewise, feel free to add the SPD class to any bus driver I might have > missed. > = > Signed-off-by: Jean Delvare > --- > =A0drivers/i2c/busses/i2c-ali1535.c =A0 =A0 =A0 | =A0 =A02 +- > =A0drivers/i2c/busses/i2c-ali1563.c =A0 =A0 =A0 | =A0 =A02 +- > =A0drivers/i2c/busses/i2c-ali15x3.c =A0 =A0 =A0 | =A0 =A02 +- > =A0drivers/i2c/busses/i2c-amd756.c =A0 =A0 =A0 =A0| =A0 =A02 +- > =A0drivers/i2c/busses/i2c-amd8111.c =A0 =A0 =A0 | =A0 =A02 +- > =A0drivers/i2c/busses/i2c-at91.c =A0 =A0 =A0 =A0 =A0| =A0 =A02 +- I've never heard of an AT91 board using DRAM sticks ... > =A0drivers/i2c/busses/i2c-cpm.c =A0 =A0 =A0 =A0 =A0 | =A0 =A02 +- > =A0drivers/i2c/busses/i2c-davinci.c =A0 =A0 =A0 | =A0 =A02 +- ... or a DaVinci one ... > =A0drivers/i2c/busses/i2c-elektor.c =A0 =A0 =A0 | =A0 =A02 +- > =A0drivers/i2c/busses/i2c-gpio.c =A0 =A0 =A0 =A0 =A0| =A0 =A02 +- > =A0drivers/i2c/busses/i2c-i801.c =A0 =A0 =A0 =A0 =A0| =A0 =A02 +- > =A0drivers/i2c/busses/i2c-ibm_iic.c =A0 =A0 =A0 | =A0 =A04 ++-- > =A0drivers/i2c/busses/i2c-iop3xx.c =A0 =A0 =A0 =A0| =A0 =A02 +- > =A0drivers/i2c/busses/i2c-isch.c =A0 =A0 =A0 =A0 =A0| =A0 =A02 +- > =A0drivers/i2c/busses/i2c-mpc.c =A0 =A0 =A0 =A0 =A0 | =A0 =A02 +- > =A0drivers/i2c/busses/i2c-mv64xxx.c =A0 =A0 =A0 | =A0 =A02 +- > =A0drivers/i2c/busses/i2c-nforce2.c =A0 =A0 =A0 | =A0 =A02 +- > =A0drivers/i2c/busses/i2c-ocores.c =A0 =A0 =A0 =A0| =A0 =A02 +- > =A0drivers/i2c/busses/i2c-omap.c =A0 =A0 =A0 =A0 =A0| =A0 =A02 +- ... or an OMAP one ... > =A0drivers/i2c/busses/i2c-parport-light.c | =A0 =A02 +- > =A0drivers/i2c/busses/i2c-parport.c =A0 =A0 =A0 | =A0 =A02 +- > =A0drivers/i2c/busses/i2c-pasemi.c =A0 =A0 =A0 =A0| =A0 =A02 +- > =A0drivers/i2c/busses/i2c-piix4.c =A0 =A0 =A0 =A0 | =A0 =A02 +- > =A0drivers/i2c/busses/i2c-pmcmsp.c =A0 =A0 =A0 =A0| =A0 =A02 +- > =A0drivers/i2c/busses/i2c-s3c2410.c =A0 =A0 =A0 | =A0 =A02 +- > =A0drivers/i2c/busses/i2c-sibyte.c =A0 =A0 =A0 =A0| =A0 =A04 ++-- > =A0drivers/i2c/busses/i2c-sis5595.c =A0 =A0 =A0 | =A0 =A02 +- > =A0drivers/i2c/busses/i2c-sis630.c =A0 =A0 =A0 =A0| =A0 =A02 +- > =A0drivers/i2c/busses/i2c-sis96x.c =A0 =A0 =A0 =A0| =A0 =A02 +- > =A0drivers/i2c/busses/i2c-stub.c =A0 =A0 =A0 =A0 =A0| =A0 =A02 +- > =A0drivers/i2c/busses/i2c-tiny-usb.c =A0 =A0 =A0| =A0 =A02 +- ... DRAM-over-USB would be bizarre too ... > =A0drivers/i2c/busses/i2c-via.c =A0 =A0 =A0 =A0 =A0 | =A0 =A02 +- > =A0drivers/i2c/busses/i2c-viapro.c =A0 =A0 =A0 =A0| =A0 =A02 +- > =A0drivers/i2c/busses/scx200_acb.c =A0 =A0 =A0 =A0| =A0 =A02 +- > =A0include/linux/i2c.h =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 =A01 + > =A035 files changed, 37 insertions(+), 36 deletions(-) _______________________________________________ i2c mailing list i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org http://lists.lm-sensors.org/mailman/listinfo/i2c