From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Cc: i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: I2C: S3C2410: Fixup error codes returned rom a transfer.
Date: Tue, 3 Jun 2008 17:28:05 +0200 [thread overview]
Message-ID: <20080603172805.04bcbea0@hyperion.delvare> (raw)
In-Reply-To: <20080602192733.802003003-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
Hi Ben,
On Mon, 02 Jun 2008 20:27:34 +0100, Ben Dooks wrote:
> The driver should be returning -ENXIO for transfers that do not
> pass the initial address byte stage.
>
> Note, also small tidyups to the driver comments in the area.
I prefer not mixing fixes with cleanups, but if you're going to push
this to Linus yourself, I don't care too much ;)
> Signed-off-by: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
>
> Index: linux-2.6.26-rc4-quilt3/drivers/i2c/busses/i2c-s3c2410.c
> ===================================================================
> --- linux-2.6.26-rc4-quilt3.orig/drivers/i2c/busses/i2c-s3c2410.c 2008-06-02 20:19:14.000000000 +0100
> +++ linux-2.6.26-rc4-quilt3/drivers/i2c/busses/i2c-s3c2410.c 2008-06-02 20:20:02.000000000 +0100
> @@ -290,12 +290,12 @@ static int i2s_s3c_irq_nextbyte(struct s
> * bus, or started a new i2c message
> */
>
> - if (iicstat & S3C2410_IICSTAT_LASTBIT &&
> + if (iicstat & S3C2410_IICSTAT_LASTBIT &&
> !(i2c->msg->flags & I2C_M_IGNORE_NAK)) {
> /* ack was not received... */
>
> dev_dbg(i2c->dev, "ack was not received\n");
> - s3c24xx_i2c_stop(i2c, -EREMOTEIO);
> + s3c24xx_i2c_stop(i2c, -ENXIO);
> goto out_ack;
> }
>
> @@ -305,7 +305,7 @@ static int i2s_s3c_irq_nextbyte(struct s
> i2c->state = STATE_WRITE;
>
> /* terminate the transfer if there is nothing to do
> - * (used by the i2c probe to find devices */
> + * as this is used by the i2c probe to find devices. */
The "as" doesn't really fit.
>
> if (is_lastmsg(i2c) && i2c->msg->len == 0) {
> s3c24xx_i2c_stop(i2c, 0);
>
Other than that, patch looks fine to me.
--
Jean Delvare
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
prev parent reply other threads:[~2008-06-03 15:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-02 19:27 I2C: S3C2410: Fixup error codes returned rom a transfer Ben Dooks
[not found] ` <20080602192733.802003003-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2008-06-03 15:28 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080603172805.04bcbea0@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox