From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH] [OF] request_module() use format string Date: Thu, 12 Jun 2008 08:27:26 +0200 Message-ID: <20080612082726.0f495687@hyperion.delvare> References: <1213246926-10043-1-git-send-email-max@stro.at> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1213246926-10043-1-git-send-email-max-U9r9yeDMy7A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org Errors-To: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org To: maximilian attems Cc: Paul Mackerras , davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org List-Id: linux-i2c@vger.kernel.org Hi Maximilian, On Thu, 12 Jun 2008 07:02:06 +0200, maximilian attems wrote: > similar to 326f6a5c9c9e1a62aec37bdc0c3f8d53adabe77b, > maybe writable by root thus worth fixing. I don't think root can affect the value of the string, but the file it is read from could be broken. So yes it seems worth fixing. > > Signed-off-by: maximilian attems > --- > drivers/of/of_i2c.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c > index b2ccdcb..117de8b 100644 > --- a/drivers/of/of_i2c.c > +++ b/drivers/of/of_i2c.c > @@ -100,7 +100,7 @@ void of_register_i2c_devices(struct i2c_adapter *adap, > > info.addr = *addr; > > - request_module(info.type); > + request_module("%s", info.type); > > result = i2c_new_device(adap, &info); > if (result == NULL) { Acked-by: Jean Delvare I think you want to send this fix to Jochen Friedrich and Paul Mackerras (both Cc'd) as they are the ones working on this driver. -- Jean Delvare _______________________________________________ i2c mailing list i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org http://lists.lm-sensors.org/mailman/listinfo/i2c